Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Pass linkable user name in Special:Preferences "Account data" help text

Browse source 
For the optional message in the "Account data" section, introduced in
d4357d621f.

Passes the user name escaped with underscores, so that links can be
built correctly in the message translation.

This means we have to expand yet further the list of User methods called
in ApiOptionsTest, but so be it.

Bug: T272412
Change-Id: Ia1c135144763db9e92f1b555f009229bd1a9d3c8
This commit is contained in:
Thalia 2021-02-16 19:38:29 +00:00 committed by James D. Forrester
parent deb624a6f8
commit 208e828a1f
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/preferences/DefaultPreferencesFactory.php
View file

@ -479,7 +479,7 @@ class DefaultPreferencesFactory implements PreferencesFactory {
],
$context->msg( 'prefs-user-downloaddata-info' )->text()
),
'help-message' => [ 'prefs-user-downloaddata-help-message', $user->getName() ],
'help-message' => [ 'prefs-user-downloaddata-help-message', $user->getTitleKey() ],
'section' => 'personal/info',
];

2
languages/i18n/qqq.json
View file

@ -1329,7 +1329,7 @@
"prefs-help-tokenmanagement": "Used in [[Special:Preferences]], Watchlist tab.",
"prefs-user-downloaddata-label": "Used in [[Special:Preferences]], tab \"User profile\".",
"prefs-user-downloaddata-info": "This message shows where to download the user's data from this wiki",
"prefs-user-downloaddata-help-message": "Used in [[Special:Preferences]], optional message for user data download help",
"prefs-user-downloaddata-help-message": "Used in [[Special:Preferences]], optional message for user data download help.\n* $1 - The user name with spaces replaced by underscores, for including in links",
"savedprefs": "This message appears after saving changes to your user preferences.",
"savedrights": "This message appears after saving the user groups on [[Special:UserRights]].\n* $1 - The user name of the user which groups was saved.",
"timezonelegend": "{{Identical|Time zone}}",

2
tests/phpunit/includes/api/ApiOptionsTest.php
View file

@ -51,7 +51,7 @@ class ApiOptionsTest extends MediaWikiLangTestCase {
'isAnon', 'getRequest', 'isLoggedIn', 'getName', 'getGroupMemberships', 'getEditCount',
'getRegistration', 'isAllowed', 'getRealName', 'getOption', 'getStubThreshold',
'getBoolOption', 'getEmail', 'getDatePreference', 'useRCPatrol', 'useNPPatrol',
'setOption', 'saveSettings', 'resetOptions', 'isRegistered'
'setOption', 'saveSettings', 'resetOptions', 'isRegistered', 'getTitleKey'
) );
// Create a new context