Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove obsolete category links code

Browse source 
* These calls and methods should no longer be needed
* Follow-up to 6dedffc2d7

Change-Id: Iff121263610117112c84edb5e575f039456d1ac8
This commit is contained in:
Aaron Schulz 2015-12-05 16:07:50 -08:00
parent 55ba12d6c4
commit 22476baa85
2 changed files with 0 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
includes/deferred/LinksUpdate.php
View file

@ -61,9 +61,6 @@ class LinksUpdate extends SqlDataUpdate implements EnqueueableDataUpdate {
/** @var bool Whether to queue jobs for recursive updates */
public $mRecursive;
/** @var bool Whether this job was triggered by a recursive update job */
private $mTriggeredRecursive;
/** @var Revision Revision for which this update has been triggered */
private $mRevision;
@ -868,15 +865,6 @@ class LinksUpdate extends SqlDataUpdate implements EnqueueableDataUpdate {
return $this->mImages;
}
/**
* Set this object as being triggered by a recursive LinksUpdate
*
* @since 1.27
*/
public function setTriggeredRecursive() {
$this->mTriggeredRecursive = true;
}
/**
* Set the revision corresponding to this LinksUpdate
*

24
includes/jobqueue/jobs/RefreshLinksJob.php
View file

@ -229,30 +229,6 @@ class RefreshLinksJob extends Job {
$parserOutput
);
foreach ( $updates as $key => $update ) {
// FIXME: move category change RC stuff to a separate update.
// RC entry addition aborts if edits where since made, which is not necessary.
// It's also an SoC violation for links update code to care about RC.
if ( $update instanceof LinksUpdate ) {
if ( !empty( $this->params['triggeredRecursive'] ) ) {
$update->setTriggeredRecursive();
}
if ( !empty( $this->params['triggeringUser'] ) ) {
$userInfo = $this->params['triggeringUser'];
if ( $userInfo['userId'] ) {
$user = User::newFromId( $userInfo['userId'] );
} else {
// Anonymous, use the username
$user = User::newFromName( $userInfo['userName'], false );
}
$update->setTriggeringUser( $user );
}
if ( !empty( $this->params['triggeringRevisionId'] ) ) {
$update->setRevision( $revision );
}
}
}
$latestNow = $page->lockAndGetLatest();
if ( !$latestNow || $revision->getId() != $latestNow ) {
// Do not clobber over newer updates with older ones. If all jobs where FIFO and