build: Updating mediawiki/mediawiki-codesniffer to 34.0.0

Change-Id: I2fb18ddd4c144655a665792901e59f88bcd906dc

composer.json

@@ -75,7 +75,7 @@
 		"hamcrest/hamcrest-php": "^2.0",
 		"johnkary/phpunit-speedtrap": "^3.1",
 		"justinrainbow/json-schema": "~5.2",
-		"mediawiki/mediawiki-codesniffer": "33.0.0",
+		"mediawiki/mediawiki-codesniffer": "34.0.0",
 		"mediawiki/mediawiki-phan-config": "0.10.4",
 		"monolog/monolog": "~2.0.2",
 		"nikic/php-parser": "4.10.2",

includes/GlobalFunctions.php

@@ -225,6 +225,7 @@ function wfArrayInsertAfter( array $array, array $insert, $after ) {
 /**
  * Recursively converts the parameter (an object) to an array with the same data
  *
+ * @phpcs:ignore MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam
  * @param object|array $objOrArray
  * @param bool $recursive
  * @return array

includes/json/JsonUnserializer.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -39,6 +40,7 @@ interface JsonUnserializer {
 	 * @note JSON objects are unconditionally unserialized as PHP associative
 	 * arrays and not as instances of \stdClass.
 	 *
+	 * @phpcs:ignore MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam
 	 * @param array|string|object $json
 	 * @param string|null $expectedClass What class to expect in unserialization.
 	 *   If null, no expectation. Must be a descendant of JsonUnserializable.

includes/libs/ReverseArrayIterator.php

@@ -36,6 +36,7 @@ class ReverseArrayIterator implements Iterator, Countable {
 	 * of the object in reverse order.  (Note that the default order
 	 * for PHP arrays and objects is declaration/assignment order.)
 	 *
+	 * @phpcs:ignore MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam
 	 * @param array|object $array
 	 */
 	public function __construct( $array = [] ) {

includes/xml/XmlJsCode.php

@@ -51,6 +51,7 @@ class XmlJsCode {
 	 * and re-encodes it as a single XmlJsCode object.
 	 *
 	 * @since 1.33
+	 * @phpcs:ignore MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam
 	 * @param object|array $obj Object or associative array to encode
 	 * @param bool $pretty If true, add non-significant whitespace to improve readability.
 	 * @return XmlJsCode

tests/phpunit/MediaWikiIntegrationTestCase.php

@@ -690,6 +690,7 @@ abstract class MediaWikiIntegrationTestCase extends PHPUnit\Framework\TestCase {
 	 * @note This calls resetServices() in case any other services depend on the set service(s).
 	 *
 	 * @param string $name
+	 * @phpcs:ignore MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam
 	 * @param object|callable $service The service instance, or a callable that returns the service instance.
 	 *
 	 * @since 1.27

tests/phpunit/includes/session/TestUtils.php

@@ -79,6 +79,7 @@ class TestUtils {
 	/**
 	 * If you need a Session for testing but don't want to create a backend to
 	 * construct one, use this.
+	 * @phpcs:ignore MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam
 	 * @param object|null $backend Object to serve as the SessionBackend
 	 * @param int $index
 	 * @param LoggerInterface|null $logger

tests/phpunit/unit/includes/language/LanguageFallbackTestTrait.php

@@ -1,5 +1,7 @@
 <?php
 
+// phpcs:disable MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam
+
 use Wikimedia\Assert\PostconditionException;
 
 /**