Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Correct field used to detect incomplete POST

Browse source 
We were using something other than the last parameter to check for an
incomplete request.  That is not guaranteed to work.

TODO:
* Is it worthwhile to take a checksum of the params as well?

Change-Id: I78f1bbcc9bb092568fbfbec19c08d697c9ae75f8
This commit is contained in:
Adam Roses Wight 2014-05-21 01:04:04 -07:00 committed by IAlex
parent 5705b0aed9
commit 262a7e2d58
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
includes/EditPage.php
View file

@ -797,9 +797,9 @@ class EditPage {
// suhosin.request.max_value_length (d'oh)
$this->incompleteForm = true;
} else {
// edittime should be one of our last fields; if it's missing,
// the submission probably broke somewhere in the middle.
$this->incompleteForm = is_null( $this->edittime );
// If we receive the last parameter of the request, we can fairly
// claim the POST request has not been truncated.
$this->incompleteForm = !$request->getVal( 'wpUltimateParam' );
}
if ( $this->incompleteForm ) {
# If the form is incomplete, force to preview.
@ -2584,6 +2584,9 @@ class EditPage {
}
}
// Marker for detecting truncated form data. This must be the last
// parameter sent in order to be of use, so do not move me.
$wgOut->addHTML( Html::hidden( 'wpUltimateParam', true ) );
$wgOut->addHTML( $this->editFormTextBottom . "\n</form>\n" );
if ( !$wgUser->getOption( 'previewontop' ) ) {