From 271da8812794176ce928978b77dbd2a6381d8193 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sat, 12 Sep 2015 15:54:13 +0200 Subject: [PATCH] Some bugzilla.wikimedia.org -> phabricator.wikimedia.org changes Changed some old bugzilla links to new phabricator links in comments, test data and error message. This reduces the need for redirects from old bugzilla to new phabricator from our source code. Change-Id: Id98278e26ce31656295a23f3cadb536859c4caa5 --- UPGRADE | 2 +- includes/GlobalFunctions.php | 2 +- includes/HtmlFormatter.php | 2 +- includes/api/ApiFormatPhp.php | 2 +- includes/db/DatabaseMysqlBase.php | 2 +- includes/db/DatabaseSqlite.php | 2 +- includes/installer/Installer.php | 4 ++-- includes/site/MediaWikiSite.php | 4 ++-- includes/specials/SpecialUserlogin.php | 2 +- languages/Language.php | 2 +- maintenance/archives/patch-archive_ar_revid.sql | 2 +- maintenance/archives/patch-backlinkindexes.sql | 2 +- .../archives/patch-categorylinksindex.sql | 2 +- maintenance/cleanupPreferences.php | 2 +- .../mediawiki.special.upload.js | 2 +- tests/phpunit/MediaWikiTestCase.php | 2 +- .../includes/GlobalFunctions/GlobalTest.php | 16 ++++++++-------- tests/phpunit/includes/HtmlFormatterTest.php | 2 +- tests/phpunit/includes/actions/ActionTest.php | 6 +++--- tests/phpunit/includes/api/ApiBlockTest.php | 4 ++-- tests/phpunit/includes/api/ApiUploadTest.php | 2 +- .../includes/api/format/ApiFormatPhpTest.php | 2 +- .../phpunit/includes/parser/PreprocessorTest.php | 2 +- .../mediawiki/mediawiki.jqueryMsg.test.js | 2 +- .../suites/resources/mediawiki/mediawiki.test.js | 2 +- 25 files changed, 37 insertions(+), 37 deletions(-) diff --git a/UPGRADE b/UPGRADE index 1ff98cdae41..088701a3eba 100644 --- a/UPGRADE +++ b/UPGRADE @@ -5,7 +5,7 @@ specific problems, check * the documentation at https://www.mediawiki.org * the mediawiki-l mailing list archive at http://lists.wikimedia.org/pipermail/mediawiki-l/ -* the bug tracker at https://bugzilla.wikimedia.org +* the bug tracker at https://phabricator.wikimedia.org for information and workarounds to common issues. diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php index 486926f2871..404d2cf1bbb 100644 --- a/includes/GlobalFunctions.php +++ b/includes/GlobalFunctions.php @@ -635,7 +635,7 @@ function wfExpandUrl( $url, $defaultProto = PROTO_CURRENT ) { $bits = wfParseUrl( $url ); // ensure proper port for HTTPS arrives in URL - // https://bugzilla.wikimedia.org/show_bug.cgi?id=65184 + // https://phabricator.wikimedia.org/T67184 if ( $defaultProto === PROTO_HTTPS && $wgHttpsPort != 443 ) { $bits['port'] = $wgHttpsPort; } diff --git a/includes/HtmlFormatter.php b/includes/HtmlFormatter.php index 221cefbb3a5..83db268e84b 100644 --- a/includes/HtmlFormatter.php +++ b/includes/HtmlFormatter.php @@ -75,7 +75,7 @@ class HtmlFormatter { // Workaround for bug that caused spaces before references // to disappear during processing: - // https://bugzilla.wikimedia.org/show_bug.cgi?id=53086 + // https://phabricator.wikimedia.org/T55086 // // Please replace with a better fix if one can be found. $html = str_replace( ' <', ' <', $html ); diff --git a/includes/api/ApiFormatPhp.php b/includes/api/ApiFormatPhp.php index 6420a5b5189..df9d581f066 100644 --- a/includes/api/ApiFormatPhp.php +++ b/includes/api/ApiFormatPhp.php @@ -69,7 +69,7 @@ class ApiFormatPhp extends ApiFormatBase { ) { $this->dieUsage( 'This response cannot be represented using format=php. ' . - 'See https://bugzilla.wikimedia.org/show_bug.cgi?id=66776', + 'See https://phabricator.wikimedia.org/T68776', 'internalerror' ); } diff --git a/includes/db/DatabaseMysqlBase.php b/includes/db/DatabaseMysqlBase.php index be34242bdad..1f87055d0bf 100644 --- a/includes/db/DatabaseMysqlBase.php +++ b/includes/db/DatabaseMysqlBase.php @@ -302,7 +302,7 @@ abstract class DatabaseMysqlBase extends DatabaseBase { // We are not checking for any errors here, since // these are no errors mysql_num_rows can cause. // See http://dev.mysql.com/doc/refman/5.0/en/mysql-fetch-row.html. - // See https://bugzilla.wikimedia.org/42430 + // See https://phabricator.wikimedia.org/T44430 return $n; } diff --git a/includes/db/DatabaseSqlite.php b/includes/db/DatabaseSqlite.php index 656547b52eb..7ece56d3366 100644 --- a/includes/db/DatabaseSqlite.php +++ b/includes/db/DatabaseSqlite.php @@ -806,7 +806,7 @@ class DatabaseSqlite extends DatabaseBase { // https://bugs.php.net/bug.php?id=62361 // There is an additional bug regarding sorting this data after insert // on older versions of sqlite shipped with ubuntu 12.04 - // https://bugzilla.wikimedia.org/show_bug.cgi?id=72367 + // https://phabricator.wikimedia.org/T74367 wfDebugLog( __CLASS__, __FUNCTION__ . ': Quoting value containing null byte. For consistency all binary data should have been first processed with self::encodeBlob()' ); return "x'" . bin2hex( $s ) . "'"; } else { diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php index 662469b9138..72e11dbb7e6 100644 --- a/includes/installer/Installer.php +++ b/includes/installer/Installer.php @@ -534,7 +534,7 @@ abstract class Installer { // then some poorly-formed extensions try to call their own classes // after immediately registering them. We really need to get extension // registration out of the global scope and into a real format. - // @see https://bugzilla.wikimedia.org/67440 + // @see https://phabricator.wikimedia.org/T69440 global $wgAutoloadClasses; $wgAutoloadClasses = array(); @@ -1477,7 +1477,7 @@ abstract class Installer { * want here is $wgHooks['LoadExtensionSchemaUpdates']. This won't work * if the extension has hidden hook registration in $wgExtensionFunctions, * but we're not opening that can of worms - * @see https://bugzilla.wikimedia.org/show_bug.cgi?id=26857 + * @see https://phabricator.wikimedia.org/T28857 */ global $wgAutoloadClasses; $wgAutoloadClasses = array(); diff --git a/includes/site/MediaWikiSite.php b/includes/site/MediaWikiSite.php index 95631f8e95c..029919c49dd 100644 --- a/includes/site/MediaWikiSite.php +++ b/includes/site/MediaWikiSite.php @@ -113,9 +113,9 @@ class MediaWikiSite extends Site { return $t->getPrefixedText(); } else { - // Make sure the string is normalized into NFC (due to the bug 40017) + // Make sure the string is normalized into NFC (due to T42017) // but do nothing to the whitespaces, that should work appropriately. - // @see https://bugzilla.wikimedia.org/show_bug.cgi?id=40017 + // @see https://phabricator.wikimedia.org/T42017 $pageName = UtfNormal\Validator::cleanUp( $pageName ); // Build the args for the specific call diff --git a/includes/specials/SpecialUserlogin.php b/includes/specials/SpecialUserlogin.php index 21f1194fcdd..ee78a61d279 100644 --- a/includes/specials/SpecialUserlogin.php +++ b/includes/specials/SpecialUserlogin.php @@ -1380,7 +1380,7 @@ class LoginForm extends SpecialPage { if ( $this->mType == 'signup' ) { // XXX hack pending RL or JS parse() support for complex content messages - // https://bugzilla.wikimedia.org/show_bug.cgi?id=25349 + // https://phabricator.wikimedia.org/T27349 $out->addJsConfigVars( 'wgCreateacctImgcaptchaHelp', $this->msg( 'createacct-imgcaptcha-help' )->parse() ); diff --git a/languages/Language.php b/languages/Language.php index 16135361298..8265d691da7 100644 --- a/languages/Language.php +++ b/languages/Language.php @@ -2678,7 +2678,7 @@ class Language { # Even with //IGNORE iconv can whine about illegal characters in # *input* string. We just ignore those too. # REF: http://bugs.php.net/bug.php?id=37166 - # REF: https://bugzilla.wikimedia.org/show_bug.cgi?id=16885 + # REF: https://phabricator.wikimedia.org/T18885 MediaWiki\suppressWarnings(); $text = iconv( $in, $out . '//IGNORE', $string ); MediaWiki\restoreWarnings(); diff --git a/maintenance/archives/patch-archive_ar_revid.sql b/maintenance/archives/patch-archive_ar_revid.sql index 3b3fdee667d..f3b9c3c9709 100644 --- a/maintenance/archives/patch-archive_ar_revid.sql +++ b/maintenance/archives/patch-archive_ar_revid.sql @@ -1,3 +1,3 @@ -- Hopefully temporary index. --- For https://bugzilla.wikimedia.org/show_bug.cgi?id=21279 +-- For https://phabricator.wikimedia.org/T23279 CREATE INDEX /*i*/ar_revid ON /*$wgDBprefix*/archive ( ar_rev_id ); \ No newline at end of file diff --git a/maintenance/archives/patch-backlinkindexes.sql b/maintenance/archives/patch-backlinkindexes.sql index 22cc587119f..9a991b81f6a 100644 --- a/maintenance/archives/patch-backlinkindexes.sql +++ b/maintenance/archives/patch-backlinkindexes.sql @@ -1,7 +1,7 @@ -- -- patch-backlinkindexes.sql -- --- Per bug 6440 / http://bugzilla.wikimedia.org/show_bug.cgi?id=6440 +-- Per task T8440 / https://phabricator.wikimedia.org/T8440 -- -- Improve performance of the "what links here"-type queries -- diff --git a/maintenance/archives/patch-categorylinksindex.sql b/maintenance/archives/patch-categorylinksindex.sql index 24ad84fe5fd..e2b2c3acc2a 100644 --- a/maintenance/archives/patch-categorylinksindex.sql +++ b/maintenance/archives/patch-categorylinksindex.sql @@ -1,7 +1,7 @@ -- -- patch-categorylinksindex.sql -- --- Per bug 10280 / http://bugzilla.wikimedia.org/show_bug.cgi?id=10280 +-- Per task T12280 / https://phabricator.wikimedia.org/T12280 -- -- Improve enum continuation performance of the what pages belong to a category query -- diff --git a/maintenance/cleanupPreferences.php b/maintenance/cleanupPreferences.php index 06ae17fbcb3..4e19b79d99e 100644 --- a/maintenance/cleanupPreferences.php +++ b/maintenance/cleanupPreferences.php @@ -19,7 +19,7 @@ * * @file * @author TyA - * @see [[bugzilla:30976]] + * @see https://phabricator.wikimedia.org/T32976 * @ingroup Maintenance */ diff --git a/resources/src/mediawiki.special/mediawiki.special.upload.js b/resources/src/mediawiki.special/mediawiki.special.upload.js index 677d26d7986..c6ae5ac726a 100644 --- a/resources/src/mediawiki.special/mediawiki.special.upload.js +++ b/resources/src/mediawiki.special/mediawiki.special.upload.js @@ -263,7 +263,7 @@ * * TODO: Is there a way we can ask the browser what's supported in ``s? * - * TODO: Put SVG back after working around Firefox 7 bug + * TODO: Put SVG back after working around Firefox 7 bug * * @param {File} file * @return {boolean} diff --git a/tests/phpunit/MediaWikiTestCase.php b/tests/phpunit/MediaWikiTestCase.php index 7dc7027afba..ec95665efd5 100644 --- a/tests/phpunit/MediaWikiTestCase.php +++ b/tests/phpunit/MediaWikiTestCase.php @@ -1151,7 +1151,7 @@ abstract class MediaWikiTestCase extends PHPUnit_Framework_TestCase { /** * Note: we are overriding this method to remove the deprecated error - * @see https://bugzilla.wikimedia.org/show_bug.cgi?id=69505 + * @see https://phabricator.wikimedia.org/T71505 * @see https://github.com/sebastianbergmann/phpunit/issues/1292 * @deprecated * diff --git a/tests/phpunit/includes/GlobalFunctions/GlobalTest.php b/tests/phpunit/includes/GlobalFunctions/GlobalTest.php index e89e36f691c..69dcd4c9826 100644 --- a/tests/phpunit/includes/GlobalFunctions/GlobalTest.php +++ b/tests/phpunit/includes/GlobalFunctions/GlobalTest.php @@ -551,10 +551,10 @@ class GlobalTest extends MediaWikiTestCase { public static function provideMakeUrlIndexes() { return array( + // Testcase for T30627 array( - // just a regular :) - 'https://bugzilla.wikimedia.org/show_bug.cgi?id=28627', - array( 'https://org.wikimedia.bugzilla./show_bug.cgi?id=28627' ) + 'https://example.org/test.cgi?id=12345', + array( 'https://org.example./test.cgi?id=12345' ) ), array( // mailtos are handled special @@ -563,7 +563,7 @@ class GlobalTest extends MediaWikiTestCase { array( 'mailto:org.wikimedia@wiki.' ) ), - // file URL cases per bug 28627... + // file URL cases per T30627... array( // three slashes: local filesystem path Unix-style 'file:///whatever/you/like.txt', @@ -587,12 +587,12 @@ class GlobalTest extends MediaWikiTestCase { // Those will survive the algorithm but with results that // are less consistent. - // protocol-relative URL cases per bug 29854... + // protocol-relative URL cases per T31854... array( - '//bugzilla.wikimedia.org/show_bug.cgi?id=28627', + '//example.org/test.cgi?id=12345', array( - 'http://org.wikimedia.bugzilla./show_bug.cgi?id=28627', - 'https://org.wikimedia.bugzilla./show_bug.cgi?id=28627' + 'http://org.example./test.cgi?id=12345', + 'https://org.example./test.cgi?id=12345' ) ), ); diff --git a/tests/phpunit/includes/HtmlFormatterTest.php b/tests/phpunit/includes/HtmlFormatterTest.php index 1c3e8539c7b..df54914ddb1 100644 --- a/tests/phpunit/includes/HtmlFormatterTest.php +++ b/tests/phpunit/includes/HtmlFormatterTest.php @@ -114,7 +114,7 @@ class HtmlFormatterTest extends MediaWikiTestCase { array(), $removeTags, // Have some rules to trigger a DOM parse ), - // https://bugzilla.wikimedia.org/show_bug.cgi?id=53086 + // https://phabricator.wikimedia.org/T55086 array( 'Foo[1]' . ' Bar', diff --git a/tests/phpunit/includes/actions/ActionTest.php b/tests/phpunit/includes/actions/ActionTest.php index 3babb97f091..63e0c8e8d53 100644 --- a/tests/phpunit/includes/actions/ActionTest.php +++ b/tests/phpunit/includes/actions/ActionTest.php @@ -92,7 +92,7 @@ class ActionTest extends MediaWikiTestCase { } public function testGetActionName_editredlinkWorkaround() { - // See https://bugzilla.wikimedia.org/show_bug.cgi?id=20966 + // See https://phabricator.wikimedia.org/T22966 $context = $this->getContext( 'editredlink' ); $actionName = Action::getActionName( $context ); @@ -100,7 +100,7 @@ class ActionTest extends MediaWikiTestCase { } public function testGetActionName_historysubmitWorkaround() { - // See https://bugzilla.wikimedia.org/show_bug.cgi?id=20966 + // See https://phabricator.wikimedia.org/T22966 $context = $this->getContext( 'historysubmit' ); $actionName = Action::getActionName( $context ); @@ -108,7 +108,7 @@ class ActionTest extends MediaWikiTestCase { } public function testGetActionName_revisiondeleteWorkaround() { - // See https://bugzilla.wikimedia.org/show_bug.cgi?id=20966 + // See https://phabricator.wikimedia.org/T22966 $context = $this->getContext( 'historysubmit' ); $context->getRequest()->setVal( 'revisiondelete', true ); $actionName = Action::getActionName( $context ); diff --git a/tests/phpunit/includes/api/ApiBlockTest.php b/tests/phpunit/includes/api/ApiBlockTest.php index 575efd6df1b..d499a759abb 100644 --- a/tests/phpunit/includes/api/ApiBlockTest.php +++ b/tests/phpunit/includes/api/ApiBlockTest.php @@ -30,11 +30,11 @@ class ApiBlockTest extends ApiTestCase { /** * This test has probably always been broken and use an invalid token - * Bug tracking brokenness is https://bugzilla.wikimedia.org/35646 + * Bug tracking brokenness is https://phabricator.wikimedia.org/T37646 * * Root cause is https://gerrit.wikimedia.org/r/3434 * Which made the Block/Unblock API to actually verify the token - * previously always considered valid (bug 34212). + * previously always considered valid (T37646). */ public function testMakeNormalBlock() { $tokens = $this->getTokens(); diff --git a/tests/phpunit/includes/api/ApiUploadTest.php b/tests/phpunit/includes/api/ApiUploadTest.php index c852d72bc68..40de254e7b6 100644 --- a/tests/phpunit/includes/api/ApiUploadTest.php +++ b/tests/phpunit/includes/api/ApiUploadTest.php @@ -11,7 +11,7 @@ * @todo Port the other Upload tests, and other API tests to this framework * * @todo Broken test, reports false errors from time to time. - * See https://bugzilla.wikimedia.org/26169 + * See https://phabricator.wikimedia.org/T28169 * * @todo This is pretty sucky... needs to be prettified. * diff --git a/tests/phpunit/includes/api/format/ApiFormatPhpTest.php b/tests/phpunit/includes/api/format/ApiFormatPhpTest.php index 0cb44e921d4..09c7c0ce59f 100644 --- a/tests/phpunit/includes/api/format/ApiFormatPhpTest.php +++ b/tests/phpunit/includes/api/format/ApiFormatPhpTest.php @@ -134,7 +134,7 @@ class ApiFormatPhpTest extends ApiFormatTestBase { } catch ( UsageException $ex ) { ob_end_clean(); $this->assertSame( - 'This response cannot be represented using format=php. See https://bugzilla.wikimedia.org/show_bug.cgi?id=66776', + 'This response cannot be represented using format=php. See https://phabricator.wikimedia.org/T68776', $ex->getMessage(), 'Expected exception' ); diff --git a/tests/phpunit/includes/parser/PreprocessorTest.php b/tests/phpunit/includes/parser/PreprocessorTest.php index 345fd0a524d..1ebba1a5e20 100644 --- a/tests/phpunit/includes/parser/PreprocessorTest.php +++ b/tests/phpunit/includes/parser/PreprocessorTest.php @@ -193,7 +193,7 @@ class PreprocessorTest extends MediaWikiTestCase { } /** - * Tests from Bug 28642 · https://bugzilla.wikimedia.org/28642 + * Tests from T30642 · https://phabricator.wikimedia.org/T30642 */ public static function provideHeadings() { // @codingStandardsIgnoreStart Ignore Generic.Files.LineLength.TooLong diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js index e7f4517548b..161b8e1b85c 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js @@ -41,7 +41,7 @@ 'gender-msg-currentuser': '{{GENDER:|blue|pink|green}}', 'plural-msg': 'Found $1 {{PLURAL:$1|item|items}}', - // See https://bugzilla.wikimedia.org/69993 + // See https://phabricator.wikimedia.org/T71993 'plural-msg-explicit-forms-nested': 'Found {{PLURAL:$1|$1 results|0=no results in {{SITENAME}}|1=$1 result}}', // Assume the grammar form grammar_case_foo is not valid in any language 'grammar-msg': 'Przeszukaj {{GRAMMAR:grammar_case_foo|{{SITENAME}}}}', diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js index 111d85bd54e..cec05520717 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js @@ -186,7 +186,7 @@ hello = mw.message( 'hello' ); - // https://bugzilla.wikimedia.org/show_bug.cgi?id=44459 + // https://phabricator.wikimedia.org/T46459 assert.equal( hello.format, 'text', 'Message property "format" defaults to "text"' ); assert.strictEqual( hello.map, mw.messages, 'Message property "map" defaults to the global instance in mw.messages' );