Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Drop the transcache table from the schema

Browse source 
Bug: T189702
Change-Id: I3286a99165953392126fcff07d565738863de6a1
This commit is contained in:
Aaron Schulz 2018-08-28 10:44:03 -07:00
parent 3f0ecb9227
commit 27a2aceb25
16 changed files with 5 additions and 90 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
includes/installer/DatabaseUpdater.php
View file

@ -1153,21 +1153,6 @@ abstract class DatabaseUpdater {
}
}
/**
* Updates the timestamps in the transcache table
* @return bool
*/
protected function doUpdateTranscacheField() {
if ( $this->updateRowExists( 'convert transcache field' ) ) {
$this->output( "...transcache tc_time already converted.\n" );
return true;
}
return $this->applyPatch( 'patch-tc-timestamp.sql', false,
"Converting tc_time from UNIX epoch to MediaWiki timestamp" );
}
/**
* Update CategoryLinks collation
*/

1
includes/installer/MssqlUpdater.php
View file

@ -145,6 +145,7 @@ class MssqlUpdater extends DatabaseUpdater {
[ 'addIndex', 'page_props', 'PRIMARY', 'patch-page_props-pk.sql' ],
[ 'addIndex', 'site_identifiers', 'PRIMARY', 'patch-site_identifiers-pk.sql' ],
[ 'addIndex', 'recentchanges', 'rc_this_oldid', 'patch-recentchanges-rc_this_oldid-index.sql' ],
[ 'dropTable', 'transcache' ],
];
}

4
includes/installer/MysqlUpdater.php
View file

@ -84,7 +84,6 @@ class MysqlUpdater extends DatabaseUpdater {
[ 'doUserGroupsUpdate' ],
[ 'addField', 'site_stats', 'ss_total_pages', 'patch-ss_total_articles.sql' ],
[ 'addTable', 'user_newtalk', 'patch-usernewtalk.sql' ],
[ 'addTable', 'transcache', 'patch-transcache.sql' ],
[ 'addField', 'interwiki', 'iw_trans', 'patch-interwiki-trans.sql' ],
// 1.6
@ -172,7 +171,6 @@ class MysqlUpdater extends DatabaseUpdater {
[ 'addTable', 'l10n_cache', 'patch-l10n_cache.sql' ],
[ 'addIndex', 'change_tag', 'change_tag_rc_tag', 'patch-change_tag-indexes.sql' ],
[ 'addField', 'redirect', 'rd_interwiki', 'patch-rd_interwiki.sql' ],
[ 'doUpdateTranscacheField' ],
[ 'doUpdateMimeMinorField' ],
// 1.17
@ -319,7 +317,6 @@ class MysqlUpdater extends DatabaseUpdater {
[ 'renameIndex', 'querycache_info', 'qci_type', 'PRIMARY', false,
'patch-querycache_info-fix-pk.sql' ],
[ 'renameIndex', 'site_stats', 'ss_row_id', 'PRIMARY', false, 'patch-site_stats-fix-pk.sql' ],
[ 'renameIndex', 'transcache', 'tc_url_idx', 'PRIMARY', false, 'patch-transcache-fix-pk.sql' ],
[ 'renameIndex', 'user_former_groups', 'ufg_user_group', 'PRIMARY', false,
'patch-user_former_groups-fix-pk.sql' ],
[ 'renameIndex', 'user_properties', 'user_properties_user_property', 'PRIMARY', false,
@ -368,6 +365,7 @@ class MysqlUpdater extends DatabaseUpdater {
[ 'renameIndex', 'site_identifiers', 'site_ids_type', 'PRIMARY', false,
'patch-site_identifiers-fix-pk.sql' ],
[ 'addIndex', 'recentchanges', 'rc_this_oldid', 'patch-recentchanges-rc_this_oldid-index.sql' ],
[ 'dropTable', 'transcache' ],
];
}

1
includes/installer/OracleUpdater.php
View file

@ -156,6 +156,7 @@ class OracleUpdater extends DatabaseUpdater {
[ 'addIndex', 'archive', 'ar_revid_uniq', 'patch-archive-ar_rev_id-unique.sql' ],
[ 'populateContentTables' ],
[ 'addIndex', 'recentchanges', 'rc_this_oldid', 'patch-recentchanges-rc_this_oldid-index.sql' ],
[ 'dropTable', 'transcache' ],
// KEEP THIS AT THE BOTTOM!!
[ 'doRebuildDuplicateFunction' ],

1
includes/installer/PostgresUpdater.php
View file

@ -591,6 +591,7 @@ class PostgresUpdater extends DatabaseUpdater {
[ 'addIndex', 'protected_titles', 'protected_titles_pkey', 'patch-protected_titles-pk.sql' ],
[ 'addIndex', 'site_identifiers', 'site_identifiers_pkey', 'patch-site_identifiers-pk.sql' ],
[ 'addPgIndex', 'recentchanges', 'rc_this_oldid', '(rc_this_oldid)' ],
[ 'dropTable', 'transcache' ],
];
}

3
includes/installer/SqliteUpdater.php
View file

@ -56,7 +56,6 @@ class SqliteUpdater extends DatabaseUpdater {
[ 'addTable', 'l10n_cache', 'patch-l10n_cache.sql' ],
[ 'addIndex', 'change_tag', 'change_tag_rc_tag', 'patch-change_tag-indexes.sql' ],
[ 'addField', 'redirect', 'rd_interwiki', 'patch-rd_interwiki.sql' ],
[ 'doUpdateTranscacheField' ],
[ 'sqliteSetupSearchindex' ],
// 1.17
@ -184,7 +183,6 @@ class SqliteUpdater extends DatabaseUpdater {
[ 'renameIndex', 'querycache_info', 'qci_type', 'PRIMARY', false,
'patch-querycache_info-fix-pk.sql' ],
[ 'renameIndex', 'site_stats', 'ss_row_id', 'PRIMARY', false, 'patch-site_stats-fix-pk.sql' ],
[ 'renameIndex', 'transcache', 'tc_url_idx', 'PRIMARY', false, 'patch-transcache-fix-pk.sql' ],
[ 'renameIndex', 'user_former_groups', 'ufg_user_group', 'PRIMARY', false,
'patch-user_former_groups-fix-pk.sql' ],
[ 'renameIndex', 'user_properties', 'user_properties_user_property', 'PRIMARY', false,
@ -232,6 +230,7 @@ class SqliteUpdater extends DatabaseUpdater {
[ 'renameIndex', 'site_identifiers', 'site_ids_type', 'PRIMARY', false,
'patch-site_identifiers-fix-pk.sql' ],
[ 'addIndex', 'recentchanges', 'rc_this_oldid', 'patch-recentchanges-rc_this_oldid-index.sql' ],
[ 'dropTable', 'transcache' ],
];
}

4
maintenance/archives/patch-tc-timestamp.sql
View file

@ -1,4 +0,0 @@
ALTER TABLE /*_*/transcache MODIFY tc_time binary(14);
UPDATE /*_*/transcache SET tc_time = DATE_FORMAT(FROM_UNIXTIME(tc_time), "%Y%c%d%H%i%s");
INSERT INTO /*_*/updatelog(ul_key) VALUES ('convert transcache field');

1
maintenance/archives/patch-transcache-fix-pk.sql
View file

@ -1 +0,0 @@
ALTER TABLE /*_*/transcache DROP KEY /*i*/tc_url_idx, ADD PRIMARY KEY (tc_url);

7
maintenance/archives/patch-transcache.sql
View file

@ -1,7 +0,0 @@
CREATE TABLE /*$wgDBprefix*/transcache (
tc_url varbinary(255) NOT NULL,
tc_contents TEXT,
tc_time binary(14) NOT NULL,
UNIQUE INDEX tc_url_idx(tc_url)
) /*$wgDBTableOptions*/;

12
maintenance/mssql/tables.sql
View file

@ -1149,18 +1149,6 @@ CREATE TABLE /*_*/objectcache (
CREATE INDEX /*i*/exptime ON /*_*/objectcache (exptime);
--
-- Cache of interwiki transclusion
--
CREATE TABLE /*_*/transcache (
tc_url nvarchar(255) NOT NULL,
tc_contents nvarchar(max),
tc_time varchar(14) NOT NULL
);
CREATE UNIQUE INDEX /*i*/tc_url_idx ON /*_*/transcache (tc_url);
CREATE TABLE /*_*/logging (
-- Log ID, for referring to this specific log entry, probably for deletion and such.
log_id int NOT NULL PRIMARY KEY IDENTITY(0,1),

7
maintenance/oracle/tables.sql
View file

@ -775,13 +775,6 @@ CREATE TABLE &mw_prefix.objectcache (
);
CREATE INDEX &mw_prefix.objectcache_i01 ON &mw_prefix.objectcache (exptime);
CREATE TABLE &mw_prefix.transcache (
tc_url VARCHAR2(255) NOT NULL,
tc_contents CLOB NOT NULL,
tc_time TIMESTAMP(6) WITH TIME ZONE NOT NULL
);
CREATE UNIQUE INDEX &mw_prefix.transcache_u01 ON &mw_prefix.transcache (tc_url);
CREATE SEQUENCE logging_log_id_seq;
CREATE TABLE &mw_prefix.logging (

6
maintenance/postgres/tables.sql
View file

@ -647,12 +647,6 @@ CREATE TABLE objectcache (
);
CREATE INDEX objectcacache_exptime ON objectcache (exptime);
CREATE TABLE transcache (
tc_url TEXT NOT NULL UNIQUE,
tc_contents TEXT NOT NULL,
tc_time TIMESTAMPTZ NOT NULL
);
CREATE SEQUENCE logging_log_id_seq;
CREATE TABLE logging (

8
maintenance/sqlite/archives/initial-indexes.sql
View file

@ -394,14 +394,6 @@ CREATE UNIQUE INDEX /*i*/si_page ON /*_*/searchindex (si_page);
CREATE INDEX /*i*/si_title ON /*_*/searchindex (si_title);
CREATE INDEX /*i*/si_text ON /*_*/searchindex (si_text);
DROP TABLE IF EXISTS /*_*/transcache;
CREATE TABLE /*_*/transcache (
tc_url varbinary(255) NOT NULL,
tc_contents text,
tc_time int NOT NULL
) /*$wgDBTableOptions*/;
CREATE UNIQUE INDEX /*i*/tc_url_idx ON /*_*/transcache (tc_url);
DROP TABLE IF EXISTS /*_*/querycache_info;
CREATE TABLE /*_*/querycache_info (
qci_type varbinary(32) NOT NULL default '',

3
maintenance/sqlite/archives/patch-tc-timestamp.sql
View file

@ -1,3 +0,0 @@
UPDATE /*_*/transcache SET tc_time = strftime('%Y%m%d%H%M%S', datetime(tc_time, 'unixepoch'));
INSERT INTO /*_*/updatelog (ul_key) VALUES ('convert transcache field');

12
maintenance/sqlite/archives/patch-transcache-fix-pk.sql
View file

@ -1,12 +0,0 @@
CREATE TABLE /*_*/transcache_tmp (
tc_url varbinary(255) NOT NULL PRIMARY KEY,
tc_contents text,
tc_time binary(14) NOT NULL
) /*$wgDBTableOptions*/;
INSERT INTO /*_*/transcache_tmp
SELECT * FROM /*_*/transcache;
DROP TABLE /*_*/transcache;
ALTER TABLE /*_*/transcache_tmp RENAME TO /*_*/transcache;

10
maintenance/tables.sql
View file

@ -1584,16 +1584,6 @@ CREATE TABLE /*_*/objectcache (
CREATE INDEX /*i*/exptime ON /*_*/objectcache (exptime);
--
-- Cache of interwiki transclusion
--
CREATE TABLE /*_*/transcache (
tc_url varbinary(255) NOT NULL PRIMARY KEY,
tc_contents text,
tc_time binary(14) NOT NULL
) /*$wgDBTableOptions*/;
CREATE TABLE /*_*/logging (
-- Log ID, for referring to this specific log entry, probably for deletion and such.
log_id int unsigned NOT NULL PRIMARY KEY AUTO_INCREMENT,