Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid full RC table scans in ChangeTags::updateTags()

Browse source 
* Various hooks that add change tags hit this code path now

Change-Id: I0b1fe7bef1e691699b2f6462ba7ac22b23253807
This commit is contained in:
Aaron Schulz 2015-08-19 02:25:18 -07:00
parent 8a1152b913
commit 285be4fd6e
1 changed files with 18 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
includes/changetags/ChangeTags.php
View file

@ -153,8 +153,10 @@ class ChangeTags {
*
* @since 1.25
*/
public static function updateTags( $tagsToAdd, $tagsToRemove, &$rc_id = null,
&$rev_id = null, &$log_id = null, $params = null ) {
public static function updateTags(
$tagsToAdd, $tagsToRemove,
&$rc_id = null, &$rev_id = null, &$log_id = null, $params = null
) {
$tagsToAdd = array_filter( (array)$tagsToAdd ); // Make sure we're submitting all tags...
$tagsToRemove = array_filter( (array)$tagsToRemove );
@ -169,18 +171,28 @@ class ChangeTags {
// Might as well look for rcids and so on.
if ( !$rc_id ) {
// Info might be out of date, somewhat fractionally, on slave.
// LogEntry/LogPage and WikiPage match rev/log/rc timestamps,
// so use that relation to avoid full table scans.
if ( $log_id ) {
$rc_id = $dbw->selectField(
'recentchanges',
array( 'logging', 'recentchanges' ),
'rc_id',
array( 'rc_logid' => $log_id ),
array(
'log_id' => $log_id,
'rc_timestamp = log_timestamp',
'rc_logid = log_id'
),
__METHOD__
);
} elseif ( $rev_id ) {
$rc_id = $dbw->selectField(
'recentchanges',
array( 'revision', 'recentchanges' ),
'rc_id',
array( 'rc_this_oldid' => $rev_id ),
array(
'rev_id' => $rev_id,
'rc_timestamp = rev_timestamp',
'rc_this_oldid = rev_id'
),
__METHOD__
);
}