Add some doc comments on Cookie::validateCookieDomain() and Http::isValidUri(), which both have some failing test cases and are incomplete

This commit is contained in:
Brion Vibber 2011-06-01 22:35:03 +00:00
parent 174b7d6a7a
commit 29aedac7db
2 changed files with 6 additions and 0 deletions

View file

@ -62,6 +62,9 @@ class Cookie {
* A better method might be to use a blacklist like
* http://publicsuffix.org/
*
* @fixme fails to detect 3-letter top-level domains
* @fixme fails to detect 2-letter top-level domains for single-domain use (probably not a big problem in practice, but there are test cases)
*
* @param $domain String: the domain to validate
* @param $originDomain String: (optional) the domain the cookie originates from
* @return Boolean

View file

@ -125,6 +125,9 @@ class Http {
* protocols, because we only want protocols that both cURL
* and php support.
*
* @fixme this is wildly inaccurate and fails to actually check most stuff
* @fixme do we actually intend to have FTP support here? Does it work consistently?
*
* @param $uri Mixed: URI to check for validity
* @returns Boolean
*/