Remove or replace usages of "sane"
Bug: T254646 Change-Id: I096b2cf738a1395a14f1d47bcbed0c2c686c2581
This commit is contained in:
parent
cee1271bfb
commit
2a2bb1e9bd
47 changed files with 56 additions and 57 deletions
|
|
@ -8366,7 +8366,7 @@ $wgExportAllowListContributors = false;
|
|||
* If non-zero, Special:Export accepts a "pagelink-depth" parameter
|
||||
* up to this specified level, which will cause it to include all
|
||||
* pages linked to from the pages you specify. Since this number
|
||||
* can become *insanely large* and could easily break your wiki,
|
||||
* can become *really really large* and could easily break your wiki,
|
||||
* it's disabled by default for now.
|
||||
*
|
||||
* @warning There's a HARD CODED limit of 5 levels of recursion to prevent a
|
||||
|
|
|
|||
|
|
@ -1311,7 +1311,8 @@ class WebRequest {
|
|||
if (
|
||||
IPUtils::isPublic( $ipchain[$i + 1] ) ||
|
||||
$wgUsePrivateIPs ||
|
||||
$proxyLookup->isConfiguredProxy( $curIP ) // T50919; treat IP as sane
|
||||
// T50919; treat IP as valid
|
||||
$proxyLookup->isConfiguredProxy( $curIP )
|
||||
) {
|
||||
$nextIP = $ipchain[$i + 1];
|
||||
|
||||
|
|
|
|||
|
|
@ -51,7 +51,7 @@ class WikiReference {
|
|||
return $parsed['host'];
|
||||
} else {
|
||||
// Invalid server spec.
|
||||
// There's no sane thing to do here, so just return the canonical server name in full.
|
||||
// There's no sensible thing to do here, so just return the canonical server name in full.
|
||||
return $this->mCanonicalServer;
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -396,7 +396,7 @@ class HistoryAction extends FormlessAction {
|
|||
$this->getTitle()->getFullURL( 'action=history' )
|
||||
);
|
||||
|
||||
// Get a limit on number of feed entries. Provide a sane default
|
||||
// Get a limit on number of feed entries. Provide a sensible default
|
||||
// of 10 if none is defined (but limit to $wgFeedLimit max)
|
||||
$limit = $request->getInt( 'limit', 10 );
|
||||
$limit = min(
|
||||
|
|
|
|||
|
|
@ -2288,7 +2288,7 @@ class ApiMain extends ApiBase {
|
|||
'',
|
||||
$idFallback
|
||||
);
|
||||
// Ensure we have a sane anchor
|
||||
// Ensure we have a sensible anchor
|
||||
if ( $id !== 'main/datatypes' && $idFallback !== 'main/datatypes' ) {
|
||||
$headline = '<div id="main/datatypes"></div>' . $headline;
|
||||
}
|
||||
|
|
@ -2335,7 +2335,7 @@ class ApiMain extends ApiBase {
|
|||
'',
|
||||
$idFallback
|
||||
);
|
||||
// Ensure we have a sane anchor
|
||||
// Ensure we have a sensible anchor
|
||||
if ( $id !== 'main/templatedparams' && $idFallback !== 'main/templatedparams' ) {
|
||||
$headline = '<div id="main/templatedparams"></div>' . $headline;
|
||||
}
|
||||
|
|
@ -2363,7 +2363,7 @@ class ApiMain extends ApiBase {
|
|||
'',
|
||||
$idFallback
|
||||
);
|
||||
// Ensure we have a sane anchor
|
||||
// Ensure we have a sensible anchor
|
||||
if ( $id !== 'main/credits' && $idFallback !== 'main/credits' ) {
|
||||
$headline = '<div id="main/credits"></div>' . $headline;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -258,7 +258,7 @@ class ApiQueryAllUsers extends ApiQueryBase {
|
|||
|
||||
if ( $lastUser === $row->user_name ) {
|
||||
// Duplicate row due to one of the needed subtable joins.
|
||||
// Ignore it, but count the number of them to sanely handle
|
||||
// Ignore it, but count the number of them to sensibly handle
|
||||
// miscalculation of $maxDuplicateRows.
|
||||
$countDuplicates++;
|
||||
if ( $countDuplicates == $maxDuplicateRows ) {
|
||||
|
|
|
|||
|
|
@ -106,7 +106,7 @@ class ApiUpload extends ApiBase {
|
|||
$this->dieStatus( $status );
|
||||
}
|
||||
|
||||
// Check if the uploaded file is sane
|
||||
// Check the uploaded file
|
||||
$this->verifyUpload();
|
||||
|
||||
// Check if the user has the rights to modify or overwrite the requested title
|
||||
|
|
|
|||
2
includes/cache/BacklinkCache.php
vendored
2
includes/cache/BacklinkCache.php
vendored
|
|
@ -395,7 +395,7 @@ class BacklinkCache {
|
|||
// Use $wgUpdateRowsPerJob just to encourage cache reuse for jobs.
|
||||
$this->partition( $table, $wgUpdateRowsPerJob ); // updates $this->partitionCache
|
||||
return $this->partitionCache[$table][$wgUpdateRowsPerJob]['numRows'];
|
||||
} else { // probably some sane limit
|
||||
} else {
|
||||
// Fetch the full title info, since the caller will likely need it next
|
||||
$count = iterator_count( $this->getLinkPages( $table, false, false, $max ) );
|
||||
if ( $count < $max ) { // full count
|
||||
|
|
|
|||
|
|
@ -94,7 +94,7 @@ abstract class ChannelFeed extends FeedItem {
|
|||
$mimetype = $this->contentType();
|
||||
header( "Content-type: $mimetype; charset=UTF-8" );
|
||||
|
||||
// Set a sane filename
|
||||
// Set a sensible filename
|
||||
$mimeAnalyzer = MediaWiki\MediaWikiServices::getInstance()->getMimeAnalyzer();
|
||||
$ext = $mimeAnalyzer->getExtensionFromMimeTypeOrNull( $mimetype ) ?? 'xml';
|
||||
header( "Content-Disposition: inline; filename=\"feed.{$ext}\"" );
|
||||
|
|
|
|||
|
|
@ -481,7 +481,7 @@ interface Content {
|
|||
public function convert( $toModel, $lossy = '' );
|
||||
|
||||
// @todo ImagePage and CategoryPage interfere with per-content action handlers
|
||||
// @todo nice&sane integration of GeSHi syntax highlighting
|
||||
// @todo nice integration of GeSHi syntax highlighting
|
||||
// [11:59] <vvv> Hooks are ugly; make CodeHighlighter interface and a
|
||||
// config to set the class which handles syntax highlighting
|
||||
// [12:00] <vvv> And default it to a DummyHighlighter
|
||||
|
|
|
|||
|
|
@ -319,8 +319,8 @@ class RequestContext implements IContextSource, MutableContext {
|
|||
}
|
||||
|
||||
/**
|
||||
* Accepts a language code and ensures it's sane. Outputs a cleaned up language
|
||||
* code and replaces with $wgLanguageCode if not sane.
|
||||
* Accepts a language code and ensures it's sensible. Outputs a cleaned up language
|
||||
* code and replaces with $wgLanguageCode if not sensible.
|
||||
* @param string $code Language code
|
||||
* @return string
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -66,7 +66,7 @@ class LegacyLogger extends AbstractLogger {
|
|||
private const LEVEL_INFINITY = 999;
|
||||
|
||||
/**
|
||||
* Convert \Psr\Log\LogLevel constants into int for sane comparisons
|
||||
* Convert \Psr\Log\LogLevel constants into int for sensible comparisons
|
||||
* These are the same values that Monolog uses
|
||||
*
|
||||
* @var array
|
||||
|
|
|
|||
|
|
@ -151,7 +151,7 @@ class SearchUpdate implements DeferrableUpdate {
|
|||
* $text = preg_replace( "/([{$lc}]+)'s /", "\\1 \\1's ", $text );
|
||||
* $text = preg_replace( "/([{$lc}]+)s' /", "\\1s ", $text );
|
||||
*
|
||||
* These tail-anchored regexps are insanely slow. The worst case comes
|
||||
* These tail-anchored regexps are very slow. The worst case comes
|
||||
* when Japanese or Chinese text (ie, no word spacing) is written on
|
||||
* a wiki configured for Western UTF-8 mode. The Unicode characters are
|
||||
* expanded to hex codes and the "words" are very long paragraph-length
|
||||
|
|
|
|||
|
|
@ -1425,7 +1425,7 @@ class DifferenceEngine extends ContextSource {
|
|||
}
|
||||
|
||||
/**
|
||||
* Process DiffEngine config and get a sane, usable engine
|
||||
* Process DiffEngine config and get a sensible, usable engine
|
||||
*
|
||||
* @return string 'wikidiff2', 'php', or path to an executable
|
||||
* @internal For use by this class and TextSlotDiffRenderer only.
|
||||
|
|
|
|||
|
|
@ -131,7 +131,7 @@ class MWExceptionHandler {
|
|||
if ( !$services->isServiceDisabled( 'DBLoadBalancerFactory' ) ) {
|
||||
// Rollback DBs to avoid transaction notices. This might fail
|
||||
// to rollback some databases due to connection issues or exceptions.
|
||||
// However, any sane DB driver will rollback implicitly anyway.
|
||||
// However, any sensible DB driver will rollback implicitly anyway.
|
||||
try {
|
||||
$services->getDBLoadBalancerFactory()->rollbackPrimaryChanges( __METHOD__ );
|
||||
} catch ( DBError $e2 ) {
|
||||
|
|
|
|||
|
|
@ -86,7 +86,7 @@ class ForeignAPIRepo extends FileRepo {
|
|||
// hack for description fetches
|
||||
$this->scriptDirUrl = dirname( $this->mApiBase );
|
||||
}
|
||||
// If we can cache thumbs we can guess sane defaults for these
|
||||
// If we can cache thumbs we can guess sensible defaults for these
|
||||
if ( $this->canCacheThumbs() && !$this->url ) {
|
||||
$this->url = $wgLocalFileRepo['url'];
|
||||
}
|
||||
|
|
|
|||
|
|
@ -58,7 +58,7 @@ class HTMLFormFieldCloner extends HTMLFormField {
|
|||
throw new MWException( 'HTMLFormFieldCloner called without any fields' );
|
||||
}
|
||||
|
||||
// Make sure the delete button, if explicitly specified, is sane
|
||||
// Make sure the delete button, if explicitly specified, is sensible
|
||||
if ( isset( $this->mParams['fields']['delete'] ) ) {
|
||||
$class = 'mw-htmlform-cloner-delete-button';
|
||||
$info = $this->mParams['fields']['delete'] + [
|
||||
|
|
|
|||
|
|
@ -136,7 +136,7 @@ class FSFileBackend extends FileBackendStore {
|
|||
protected function resolveContainerPath( $container, $relStoragePath ) {
|
||||
// Check that container has a root directory
|
||||
if ( isset( $this->containerPaths[$container] ) || isset( $this->basePath ) ) {
|
||||
// Check for sane relative paths (assume the base paths are OK)
|
||||
// Check for sensible relative paths (assume the base paths are OK)
|
||||
if ( $this->isLegalRelPath( $relStoragePath ) ) {
|
||||
return $relStoragePath;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -125,7 +125,7 @@ class SwiftFileBackend extends FileBackendStore {
|
|||
$this->swiftUser = $config['swiftUser'];
|
||||
$this->swiftKey = $config['swiftKey'];
|
||||
// Optional settings
|
||||
$this->authTTL = $config['swiftAuthTTL'] ?? 15 * 60; // some sane number
|
||||
$this->authTTL = $config['swiftAuthTTL'] ?? 15 * 60; // some sensible number
|
||||
$this->swiftTempUrlKey = $config['swiftTempUrlKey'] ?? '';
|
||||
$this->swiftStorageUrl = $config['swiftStorageUrl'] ?? null;
|
||||
$this->shardViaHashLevels = $config['shardViaHashLevels'] ?? '';
|
||||
|
|
|
|||
|
|
@ -89,7 +89,7 @@ abstract class DBLockManager extends QuorumLockManager {
|
|||
$this->lockExpiry = $config['lockExpiry'];
|
||||
} else {
|
||||
$met = ini_get( 'max_execution_time' );
|
||||
$this->lockExpiry = $met ?: 60; // use some sane amount if 0
|
||||
$this->lockExpiry = $met ?: 60; // use some sensible amount if 0
|
||||
}
|
||||
$this->safeDelay = ( $this->lockExpiry <= 0 )
|
||||
? 60 // pick a safe-ish number to match DB timeout default
|
||||
|
|
|
|||
|
|
@ -1755,7 +1755,7 @@ class LoadBalancer implements ILoadBalancer {
|
|||
// caught an exception but failed to properly rollback any changes. Detect that and
|
||||
// throw an error (causing rollback).
|
||||
$conn->assertNoOpenTransactions();
|
||||
// Assert that the time to replicate the transaction will be sane.
|
||||
// Assert that the time to replicate the transaction will be reasonable.
|
||||
// If this fails, then all DB transactions will be rollback back together.
|
||||
$time = $conn->pendingWriteQueryDuration( $conn::ESTIMATE_DB_APPLY );
|
||||
if ( $limit > 0 ) {
|
||||
|
|
|
|||
|
|
@ -941,7 +941,6 @@ class LogFormatter {
|
|||
case 'title-link':
|
||||
$title = Title::newFromText( $value );
|
||||
if ( !$title ) {
|
||||
// Huh? Do something halfway sane.
|
||||
$title = SpecialPage::getTitleFor( 'Badtitle', $value );
|
||||
}
|
||||
$value = [];
|
||||
|
|
|
|||
|
|
@ -110,7 +110,7 @@ class XCFHandler extends BitmapHandler {
|
|||
|
||||
return null;
|
||||
}
|
||||
# TODO: we might want to check for sane values of width and height
|
||||
# TODO: we might want to check for correct values of width and height
|
||||
|
||||
wfDebug( __METHOD__ .
|
||||
": canvas size of '$filename' is {$header['width']} x {$header['height']} px" );
|
||||
|
|
|
|||
|
|
@ -112,7 +112,7 @@ class ParserOptions {
|
|||
/**
|
||||
* Stored user object
|
||||
* @var UserIdentity
|
||||
* @todo Track this for caching somehow without fragmenting the cache insanely
|
||||
* @todo Track this for caching somehow without fragmenting the cache
|
||||
*/
|
||||
private $mUser;
|
||||
|
||||
|
|
|
|||
|
|
@ -171,8 +171,8 @@ abstract class PoolCounter {
|
|||
abstract public function release();
|
||||
|
||||
/**
|
||||
* Checks that the lock request is sane.
|
||||
* @return Status good for sane requests fatal for insane
|
||||
* Checks that the lock request is sensible.
|
||||
* @return Status good for sensible requests, fatal for the not so sensible
|
||||
* @since 1.25
|
||||
*/
|
||||
final protected function precheckAcquire() {
|
||||
|
|
|
|||
|
|
@ -416,15 +416,14 @@ class SearchMySQL extends SearchDatabase {
|
|||
|
||||
// Periods within things like hostnames and IP addresses
|
||||
// are also important -- we want a search for "example.com"
|
||||
// or "192.168.1.1" to work sanely.
|
||||
// or "192.168.1.1" to work sensibly.
|
||||
// MySQL's search seems to ignore them, so you'd match on
|
||||
// "example.wikipedia.com" and "192.168.83.1" as well.
|
||||
$out = preg_replace(
|
||||
return preg_replace(
|
||||
"/(\w)\.(\w|\*)/u",
|
||||
"$1u82e$2",
|
||||
$out );
|
||||
|
||||
return $out;
|
||||
$out
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
|||
|
|
@ -127,7 +127,7 @@ class SearchNearMatcher {
|
|||
return $title;
|
||||
}
|
||||
|
||||
# See if it still otherwise has content is some sane sense
|
||||
# See if it still otherwise has content is some sensible sense
|
||||
if ( $title->canExist() ) {
|
||||
$page = $this->wikiPageFactory->newFromTitle( $title );
|
||||
if ( $page->hasViewableContent() ) {
|
||||
|
|
|
|||
|
|
@ -138,7 +138,7 @@ class PHPSessionHandler implements \SessionHandlerInterface {
|
|||
// some user agents.
|
||||
session_cache_limiter( '' );
|
||||
|
||||
// Also set a sane serialization handler
|
||||
// Also set a serialization handler
|
||||
\Wikimedia\PhpSessionSerializer::setSerializeHandler();
|
||||
|
||||
// Register this as the save handler, and register an appropriate
|
||||
|
|
|
|||
|
|
@ -581,7 +581,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
|
|||
|
||||
/**
|
||||
* Add page elements which are outside the form.
|
||||
* FIXME this should probably be a template, but use a sane language (handlebars?)
|
||||
* FIXME this should probably be a template, but use a sensible language (handlebars?)
|
||||
* @param string $formHtml
|
||||
* @return string
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -205,7 +205,7 @@ class SpecialExport extends SpecialPage {
|
|||
$request->response()->header( 'X-Robots-Tag: noindex,nofollow' );
|
||||
|
||||
if ( $request->getCheck( 'wpDownload' ) ) {
|
||||
// Provide a sane filename suggestion
|
||||
// Provide a sensible filename suggestion
|
||||
$filename = urlencode( $config->get( 'Sitename' ) . '-' . wfTimestampNow() . '.xml' );
|
||||
$request->response()->header( "Content-disposition: attachment;filename={$filename}" );
|
||||
}
|
||||
|
|
|
|||
|
|
@ -381,7 +381,7 @@ class SpecialUpload extends SpecialPage {
|
|||
*
|
||||
* Note: only errors that can be handled by changing the name or
|
||||
* description should be redirected here. It should be assumed that the
|
||||
* file itself is sane and has passed UploadBase::verifyFile. This
|
||||
* file itself is sensible and has passed UploadBase::verifyFile. This
|
||||
* essentially means that UploadBase::VERIFICATION_ERROR and
|
||||
* UploadBase::EMPTY_FILE should not be passed here.
|
||||
*
|
||||
|
|
|
|||
|
|
@ -19,7 +19,7 @@
|
|||
*/
|
||||
|
||||
/**
|
||||
* Extend OOUIHTMLForm purely so we can have a more sane way of getting the section headers
|
||||
* Extend OOUIHTMLForm purely so we can have a more sensible way of getting the section headers
|
||||
*/
|
||||
class EditWatchlistNormalHTMLForm extends OOUIHTMLForm {
|
||||
public function getLegend( $namespace ) {
|
||||
|
|
|
|||
|
|
@ -348,7 +348,7 @@ abstract class UploadBase {
|
|||
}
|
||||
|
||||
/**
|
||||
* Verify whether the upload is sane.
|
||||
* Verify whether the upload is sensible.
|
||||
*
|
||||
* Return a status array representing the outcome of the verification.
|
||||
* Possible keys are:
|
||||
|
|
|
|||
|
|
@ -45,7 +45,7 @@ class UploadStashFile extends UnregisteredLocalFile {
|
|||
if ( FileRepo::isVirtualUrl( $path ) ) {
|
||||
$path = $repo->resolveVirtualUrl( $path );
|
||||
} else {
|
||||
// check if path appears to be sane, no parent traversals,
|
||||
// check if path appears to be correct, no parent traversals,
|
||||
// and is in this repo's temp zone.
|
||||
$repoTempPath = $repo->getZonePath( 'temp' );
|
||||
if ( ( !$repo->validateFilename( $path ) ) ||
|
||||
|
|
|
|||
|
|
@ -3325,7 +3325,7 @@ class User implements Authority, UserIdentity, UserEmailContact {
|
|||
* hardcoded English names of the Special: pages, for ASCII safety.
|
||||
*
|
||||
* @note Since these URLs get dropped directly into emails, using the
|
||||
* short English names avoids insanely long URL-encoded links, which
|
||||
* short English names avoids really long URL-encoded links, which
|
||||
* also sometimes can get corrupted in some browsers/mailers
|
||||
* (T8957 with Gmail and Internet Explorer).
|
||||
*
|
||||
|
|
|
|||
|
|
@ -2,7 +2,7 @@
|
|||
"comment": "Rename user_properties_property index to up_property (T270033)",
|
||||
"before": {
|
||||
"name": "user_properties",
|
||||
"comment": "User preferences and perhaps other fun stuff. :) Replaces the old user.user_options blob, with a couple nice properties: 1) We only store non-default settings, so changes to the defaults are now reflected for everybody, not just new accounts. 2) We can more easily do bulk lookups, statistics, or modifications of saved options since it's a sane table structure.",
|
||||
"comment": "User preferences and perhaps other fun stuff. :) Replaces the old user.user_options blob, with a couple nice properties: 1) We only store non-default settings, so changes to the defaults are now reflected for everybody, not just new accounts. 2) We can more easily do bulk lookups, statistics, or modifications of saved options since it's a sensible table structure.",
|
||||
"columns": [
|
||||
{
|
||||
"name": "up_user",
|
||||
|
|
@ -30,7 +30,7 @@
|
|||
},
|
||||
"after": {
|
||||
"name": "user_properties",
|
||||
"comment": "User preferences and perhaps other fun stuff. :) Replaces the old user.user_options blob, with a couple nice properties: 1) We only store non-default settings, so changes to the defaults are now reflected for everybody, not just new accounts. 2) We can more easily do bulk lookups, statistics, or modifications of saved options since it's a sane table structure.",
|
||||
"comment": "User preferences and perhaps other fun stuff. :) Replaces the old user.user_options blob, with a couple nice properties: 1) We only store non-default settings, so changes to the defaults are now reflected for everybody, not just new accounts. 2) We can more easily do bulk lookups, statistics, or modifications of saved options since it's a sensible table structure.",
|
||||
"columns": [
|
||||
{
|
||||
"name": "up_user",
|
||||
|
|
|
|||
|
|
@ -115,7 +115,7 @@ class GetConfiguration extends Maintenance {
|
|||
// Settings we will display
|
||||
$res = [];
|
||||
|
||||
# Sane default: dump any wg / wmg variable
|
||||
# Default: dump any wg / wmg variable
|
||||
if ( !$this->regex && !$this->getOption( 'settings' ) ) {
|
||||
$this->regex = '/^wm?g/';
|
||||
}
|
||||
|
|
|
|||
|
|
@ -498,7 +498,7 @@ class ImportImages extends Maintenance {
|
|||
}
|
||||
|
||||
/**
|
||||
* @todo FIXME: Access the api in a saner way and performing just one query
|
||||
* @todo FIXME: Access the api in a better way and performing just one query
|
||||
* (preferably batching files too).
|
||||
*
|
||||
* @param string $wiki_host
|
||||
|
|
|
|||
|
|
@ -48,7 +48,7 @@ class RenameDbPrefix extends Maintenance {
|
|||
if ( $this->getOption( 'old', 0 ) === '0' ) {
|
||||
$old = '';
|
||||
} else {
|
||||
// Use nice safe, sane, prefixes
|
||||
// Use nice safe, sensible, prefixes
|
||||
preg_match( '/^[a-zA-Z]+_$/', $this->getOption( 'old' ), $m );
|
||||
$old = $m[0] ?? false;
|
||||
}
|
||||
|
|
@ -56,7 +56,7 @@ class RenameDbPrefix extends Maintenance {
|
|||
if ( $this->getOption( 'new', 0 ) === '0' ) {
|
||||
$new = '';
|
||||
} else {
|
||||
// Use nice safe, sane, prefixes
|
||||
// Use nice safe, sensible, prefixes
|
||||
preg_match( '/^[a-zA-Z]+_$/', $this->getOption( 'new' ), $m );
|
||||
$new = $m[0] ?? false;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -263,7 +263,7 @@
|
|||
},
|
||||
{
|
||||
"name": "user_properties",
|
||||
"comment": "User preferences and perhaps other fun stuff. :) Replaces the old user.user_options blob, with a couple nice properties: 1) We only store non-default settings, so changes to the defaults are now reflected for everybody, not just new accounts. 2) We can more easily do bulk lookups, statistics, or modifications of saved options since it's a sane table structure.",
|
||||
"comment": "User preferences and perhaps other fun stuff. :) Replaces the old user.user_options blob, with a couple nice properties: 1) We only store non-default settings, so changes to the defaults are now reflected for everybody, not just new accounts. 2) We can more easily do bulk lookups, statistics, or modifications of saved options since it's a sensible table structure.",
|
||||
"columns": [
|
||||
{
|
||||
"name": "up_user",
|
||||
|
|
|
|||
|
|
@ -387,7 +387,7 @@
|
|||
// eslint-disable-next-line no-jquery/no-class-state
|
||||
if ( options.collapsed || $collapsible.hasClass( 'mw-collapsed' ) ) {
|
||||
// One toggler can hook to multiple elements, and one element can have
|
||||
// multiple togglers. This is the sanest way to handle that.
|
||||
// multiple togglers. This is the best way to handle that.
|
||||
actionHandler.call( $toggle.get( 0 ), null, { wasCollapsed: false } );
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -252,7 +252,7 @@
|
|||
numberString = String( num );
|
||||
} else {
|
||||
// This check being here means that digits can still be unformatted
|
||||
// even if we do not produce them. This seems sane behavior.
|
||||
// even if we do not produce them.
|
||||
if ( mw.config.get( 'wgTranslateNumerals' ) ) {
|
||||
transformTable = digitTransformTable;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -254,7 +254,7 @@
|
|||
|
||||
/**
|
||||
* Check if this is a recognizable image type...
|
||||
* Also excludes files over 10 MiB to avoid going insane on memory usage.
|
||||
* Also excludes files over 10 MiB to avoid excessive memory usage.
|
||||
*
|
||||
* TODO: Is there a way we can ask the browser what's supported in `<img>`s?
|
||||
*
|
||||
|
|
|
|||
|
|
@ -687,7 +687,7 @@ class ChangesListSpecialPageTest extends AbstractChangesListSpecialPageTestCase
|
|||
]
|
||||
);
|
||||
|
||||
// @todo: This is not at all safe or sane. It just blindly assumes
|
||||
// @todo: This is not at all safe or sensible. It just blindly assumes
|
||||
// nothing in $conds depends on any other tables.
|
||||
$result = wfGetDB( DB_PRIMARY )->select(
|
||||
'user',
|
||||
|
|
|
|||
|
|
@ -278,7 +278,7 @@ class ResourcesTest extends MediaWikiIntegrationTestCase {
|
|||
);
|
||||
}
|
||||
|
||||
// To populate missingLocalFileRefs. Not sure how sane this is inside this test...
|
||||
// To populate missingLocalFileRefs. Not sure how sensible this is inside this test...
|
||||
$moduleProxy->readStyleFiles(
|
||||
$module->getStyleFiles( $data['context'] ),
|
||||
$data['context']
|
||||
|
|
|
|||
|
|
@ -80689,4 +80689,4 @@
|
|||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -37,7 +37,7 @@ function filePath( title, extension ) {
|
|||
* @return {string} File path
|
||||
*/
|
||||
function saveScreenshot( title ) {
|
||||
// Create sane file name for current test title
|
||||
// Create sensible file name for current test title
|
||||
const path = filePath( title, 'png' );
|
||||
// Ensure directory exists, based on WebDriverIO#saveScreenshotSync()
|
||||
try {
|
||||
|
|
|
|||
Loading…
Reference in a new issue