Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "ParserOutput: update task id in documentation"

Browse source
This commit is contained in:
jenkins-bot 2024-02-15 23:36:35 +00:00 committed by Gerrit Code Review
commit 2ca5bb9a96
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/parser/ParserOutput.php
View file

@ -939,7 +939,7 @@ class ParserOutput extends CacheTime implements ContentMetadataCollector {
public function addLanguageLink( $t ): void { public function addLanguageLink( $t ): void {
if ( $t instanceof ParsoidLinkTarget ) { if ( $t instanceof ParsoidLinkTarget ) {
// language links are unusual in using 'text' rather than 'db key' // language links are unusual in using 'text' rather than 'db key'
// T296023: This should be made more efficient so we don't need // T296019: This should be made more efficient so we don't need
// a full title lookup. // a full title lookup.
$t = Title::newfromLinkTarget( $t )->getFullText(); $t = Title::newfromLinkTarget( $t )->getFullText();
} }
@ -1058,7 +1058,7 @@ class ParserOutput extends CacheTime implements ContentMetadataCollector {
return; return;
} }
if ( $id === null ) { if ( $id === null ) {
// T296023: This actually kills performance; we should batch these. // T357048: This actually kills performance; we should batch these.
$page = MediaWikiServices::getInstance()->getPageStore()->getPageForLink( $link ); $page = MediaWikiServices::getInstance()->getPageStore()->getPageForLink( $link );
$id = $page->getId(); $id = $page->getId();
} }
@ -1091,7 +1091,7 @@ class ParserOutput extends CacheTime implements ContentMetadataCollector {
public function addTemplate( $link, $page_id, $rev_id ): void { public function addTemplate( $link, $page_id, $rev_id ): void {
$ns = $link->getNamespace(); $ns = $link->getNamespace();
$dbk = $link->getDBkey(); $dbk = $link->getDBkey();
// T296023: Parsoid doesn't have page_id // T357048: Parsoid doesn't have page_id
$this->mTemplates[$ns][$dbk] = $page_id; $this->mTemplates[$ns][$dbk] = $page_id;
$this->mTemplateIds[$ns][$dbk] = $rev_id; // For versioning $this->mTemplateIds[$ns][$dbk] = $rev_id; // For versioning
} }