Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cache title lookups in Title::newFromText(). In pages with many duplicate links this can save time normalizing and parsing title text.

Browse source
This commit is contained in:
Brion Vibber 2004-11-26 11:47:09 +00:00
parent 7a4c860acc
commit 2d4d80953d
1 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
includes/Title.php
View file

@ -93,30 +93,48 @@ class Title {
/* static */ function &newFromText( $text, $defaultNamespace = 0 ) {
$fname = 'Title::newFromText';
wfProfileIn( $fname );
/**
* Wiki pages often contain multiple links to the same page.
* Title normalization and parsing can become expensive on
* pages with many links, so we can save a little time by
* caching them.
*
* In theory these are value objects and won't get changed...
*/
static $titleCache = array();
if( $defaultNamespace == 0 && isset( $titleCache[$text] ) ) {
wfProfileOut( $fname );
return $titleCache[$text];
}
/**
* Convert things like é into real text...
*/
global $wgInputEncoding;
$text = do_html_entity_decode( $text, ENT_COMPAT, $wgInputEncoding );
$filteredText = do_html_entity_decode( $text, ENT_COMPAT, $wgInputEncoding );
/**
* Convert things like ā or 〗 into real text...
* WARNING: Not friendly to internal links on a latin-1 wiki.
*/
$text = wfMungeToUtf8( $text );
$filteredText = wfMungeToUtf8( $filteredText );
# What was this for? TS 2004-03-03
# $text = urldecode( $text );
$t =& new Title();
$t->mDbkeyform = str_replace( ' ', '_', $text );
$t->mDbkeyform = str_replace( ' ', '_', $filteredText );
$t->mDefaultNamespace = $defaultNamespace;
if( $t->secureAndSplit() ) {
if( $defaultNamespace == 0 ) {
$titleCache[$text] =& $t;
}
wfProfileOut( $fname );
return $t;
} else {
$titleCache[$text] = null;
wfProfileOut( $fname );
return NULL;
}