Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove deprecated CommentStore::getStore

Browse source 
Bug: T325475
Change-Id: I0ff5e286cd15f45515e75fa85db529758e8f5ed9
This commit is contained in:
Umherirrender 2023-04-22 20:16:00 +02:00
parent 7b12ff8473
commit 2e020a25f0
3 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
RELEASE-NOTES-1.41
View file

@ -81,6 +81,7 @@ because of Phabricator reports.
=== Breaking changes in 1.41 ===
* Article::doDelete(), deprecated since 1.37, has been removed.
* CommentStore::getStore(), deprecated since 1.31, has been removed.
* Article::getRedirectHeaderHtml() no longer accepts an array as $target.
Passing an array was deprecated in 1.39.
* IDatabase::wasErrorReissuable(), deprecated since 1.40, has been removed.

11
includes/CommentStore/CommentStore.php
View file

@ -21,7 +21,6 @@
namespace MediaWiki\CommentStore;
use Language;
use MediaWiki\MediaWikiServices;
/**
* @defgroup CommentStore CommentStore
@ -78,16 +77,6 @@ class CommentStore extends CommentStoreBase {
$this->tempTables[$key]['stage'] = $stageOverride;
}
}
/**
* @since 1.31
* @deprecated in 1.31 Use DI to inject a CommentStore instance into your class. Hard-deprecated since 1.40.
* @return CommentStore
*/
public static function getStore() {
wfDeprecated( __METHOD__, '1.31' );
return MediaWikiServices::getInstance()->getCommentStore();
}
}
class_alias( CommentStore::class, 'CommentStore' );

5
tests/phpunit/includes/CommentStoreTest.php
View file

@ -856,9 +856,4 @@ class CommentStoreTest extends MediaWikiLangTestCase {
] );
}
public function testGetStore() {
$this->hideDeprecated( 'MediaWiki\\CommentStore\\CommentStore::getStore' );
$this->assertInstanceOf( CommentStore::class, CommentStore::getStore() );
}
}