Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "ResourceLoader: Add 1min grace via stale-while-revalidate Cache-Control"

Browse source
This commit is contained in:
jenkins-bot 2022-12-07 22:10:30 +00:00 committed by Gerrit Code Review
commit 3173f253fb
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/ResourceLoader/ResourceLoader.php
View file

@ -921,7 +921,13 @@ class ResourceLoader implements LoggerAwareInterface {
header( 'Cache-Control: private, no-cache, must-revalidate' );
header( 'Pragma: no-cache' );
} else {
header( "Cache-Control: public, max-age=$maxage, s-maxage=$maxage" );
// T132418: When a resource expires mid-way a browsing session, prefer to renew it in
// the background instead of blocking the next page load (eg. startup module, or CSS).
$staleDirective = ( $maxage > self::MAXAGE_RECOVER
? ", stale-while-revalidate=" . min( 60, intval( $maxage / 2 ) )
: ''
);
header( "Cache-Control: public, max-age=$maxage, s-maxage=$maxage" . $staleDirective );
header( 'Expires: ' . ConvertibleTimestamp::convert( TS_RFC2822, time() + $maxage ) );
}
foreach ( $extra as $header ) {