Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove three deprecated functions from the Revision class.

Browse source 
This commit removes Revision::getRawUser(), Revision::getRawUserText(), and Revision::getRawComment(). All three were deprecated in 1.25 and are only used in unmaintained extensions.

Bug: T61113
Change-Id: I729985b791df89bc7e577fb823e647c48549e637
This commit is contained in:
Matthew Bowker 2018-05-02 13:32:38 -06:00 committed by Jforrester
parent b48a74ef5f
commit 318706a27c
2 changed files with 5 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
RELEASE-NOTES-1.32
View file

@ -61,6 +61,11 @@ changes to languages because of Phabricator reports.
* EditPage::isOouiEnabled() was removed (deprecated in 1.30).
* mw.util.wikiGetlink() was removed (deprecated in 1.23).
Use mw.util.getUrl() instead.
* (T61113) The following methods and constants from the Revision class were deprecated in
1.25 and have now been removed.
* Revision::getRawUser()
* Revision::getRawUserText()
* Revision::getRawComment()
=== Deprecations in 1.32 ===
* Use of a StartProfiler.php file is deprecated in favour of placing

34
includes/Revision.php
View file

@ -786,17 +786,6 @@ class Revision implements IDBAccessObject {
return $user ? $user->getId() : 0;
}
/**
* Fetch revision's user id without regard for the current user's permissions
*
* @return int
* @deprecated since 1.25, use getUser( Revision::RAW )
*/
public function getRawUser() {
wfDeprecated( __METHOD__, '1.25' );
return $this->getUser( self::RAW );
}
/**
* Fetch revision's username if it's available to the specified audience.
* If the specified audience does not have access to the username, an
@ -820,18 +809,6 @@ class Revision implements IDBAccessObject {
$user = $this->mRecord->getUser( $audience, $user );
return $user ? $user->getName() : '';
}
/**
* Fetch revision's username without regard for view restrictions
*
* @return string
* @deprecated since 1.25, use getUserText( Revision::RAW )
*/
public function getRawUserText() {
wfDeprecated( __METHOD__, '1.25' );
return $this->getUserText( self::RAW );
}
/**
* Fetch revision comment if it's available to the specified audience.
* If the specified audience does not have access to the comment, an
@ -856,17 +833,6 @@ class Revision implements IDBAccessObject {
return $comment === null ? null : $comment->text;
}
/**
* Fetch revision comment without regard for the current user's permissions
*
* @return string
* @deprecated since 1.25, use getComment( Revision::RAW )
*/
public function getRawComment() {
wfDeprecated( __METHOD__, '1.25' );
return $this->getComment( self::RAW );
}
/**
* @return bool
*/