Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

installer: Do not wrongly hide namespace input field

Browse source 
When the radio button is already on "other" then the input field for
the namespace should not get hidden by JavaScript on load.

Also remove the readonly attribute in HTML because the readonly
attribute can not get removed with disabled JavaScript.

Change-Id: I8cfde90d791765234572caf00b731881ac2eda48
This commit is contained in:
Fomafix 2018-04-27 16:27:39 +02:00 committed by Legoktm
parent 1c52863fc0
commit 31a472655b
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/installer/WebInstallerName.php
View file

@ -76,7 +76,7 @@ class WebInstallerName extends WebInstallerPage {
$this->parent->getTextBox( [
'var' => 'wgMetaNamespace',
'label' => '', // @todo Needs a label?
'attribs' => [ 'readonly' => 'readonly', 'class' => 'enabledByOther' ]
'attribs' => [ 'class' => 'enabledByOther' ]
] ) .
$this->getFieldsetStart( 'config-admin-box' ) .
$this->parent->getTextBox( [

4
mw-config/config.js
View file

@ -73,7 +73,9 @@
// Hide "other" textboxes by default
// Should not be done in CSS for javascript disabled compatibility
$( '.enabledByOther' ).closest( '.config-block' ).hide();
if ( !$( '#config__NamespaceType_other' ).is( ':checked' ) ) {
$( '.enabledByOther' ).closest( '.config-block' ).hide();
}
// Enable/disable "other" textboxes
$( '.enableForOther' ).click( function () {