Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

exception: Use const for MWExceptionHandler::$fatalErrorTypes

Browse source 
Also remove @var from const, the type is given by the value of the const
and does not need documentation.

Change-Id: I65636f2b97b44387c4320ebfb4be6c81d6f771b9
This commit is contained in:
Umherirrender 2024-09-01 13:23:45 +02:00
parent d1c03580c5
commit 31c1011105
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
includes/exception/MWExceptionHandler.php
View file

@ -34,11 +34,11 @@ use Wikimedia\Rdbms\DBQueryError;
* @ingroup Exception
*/
class MWExceptionHandler {
/** @var string Error caught and reported by this exception handler */
/** Error caught and reported by this exception handler */
public const CAUGHT_BY_HANDLER = 'mwe_handler';
/** @var string Error caught and reported by a script entry point */
/** Error caught and reported by a script entry point */
public const CAUGHT_BY_ENTRYPOINT = 'entrypoint';
/** @var string Error reported by direct logException() call */
/** Error reported by direct logException() call */
public const CAUGHT_BY_OTHER = 'other';
/** @var string|null */
@ -51,10 +51,8 @@ class MWExceptionHandler {
* The user will be shown an HTTP 500 Internal Server Error.
* As such, these should be sent to MediaWiki's "exception" channel.
* Normally, the error handler logs them to the "error" channel.
*
* @var array
*/
protected static $fatalErrorTypes = [
private const FATAL_ERROR_TYPES = [
E_ERROR,
E_PARSE,
E_CORE_ERROR,
@ -361,7 +359,7 @@ class MWExceptionHandler {
$file = $lastError['file'];
$line = $lastError['line'];
if ( !in_array( $level, self::$fatalErrorTypes ) ) {
if ( !in_array( $level, self::FATAL_ERROR_TYPES ) ) {
// Only interested in fatal errors, others should have been
// handled by MWExceptionHandler::handleError
return false;