Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dao: Add a type hint to getConnection() and some extra newlines

Browse source 
Change-Id: I57a060394403a6b7335fda68edaeabc02888e14d
This commit is contained in:
Derick Alangi 2019-01-16 14:29:53 +01:00
parent 612f48ca5b
commit 324f03ede5
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/dao/DBAccessBase.php
View file

@ -59,7 +59,7 @@ abstract class DBAccessBase implements IDBAccessObject {
*
* @return IDatabase
*/
protected function getConnection( $id, $groups = [] ) {
protected function getConnection( $id, array $groups = [] ) {
$loadBalancer = $this->getLoadBalancer();
return $loadBalancer->getConnection( $id, $groups, $this->wiki );

3
includes/dao/IDBAccessObject.php
View file

@ -56,10 +56,13 @@ interface IDBAccessObject {
/** Constants for object loading bitfield flags (higher => higher QoS) */
/** @var int Read from a replica DB/non-quorum */
const READ_NORMAL = 0;
/** @var int Read from the master/quorum */
const READ_LATEST = 1;
/* @var int Read from the master/quorum and lock out other writers */
const READ_LOCKING = self::READ_LATEST | 2; // READ_LATEST (1) and "LOCK IN SHARE MODE" (2)
/** @var int Read from the master/quorum and lock out other writers and locking readers */
const READ_EXCLUSIVE = self::READ_LOCKING | 4; // READ_LOCKING (3) and "FOR UPDATE" (4)