Merge "Hard deprecate the onTitleArrayFromResult hook"

RELEASE-NOTES-1.36

@@ -731,6 +731,7 @@ because of Phabricator reports.
   ::authorizeMerge instead.
 * User::isValidUserName(), deprecated in 1.35, is hard deprecated.
   Use the UserNameUtils service instead.
+* The TitleArrayFromResult hook has been deprecated.
 * The EditPageBeforeEditToolbar hook has been deprecated; it has become
   defunct after the classic edit toolbar was removed. Use one of the many
   other EditPage hooks instead.

includes/Hook/TitleArrayFromResultHook.php

@@ -9,7 +9,6 @@ use Wikimedia\Rdbms\IResultWrapper;
  * This is a hook handler interface, see docs/Hooks.md.
  * Use the hook name "TitleArrayFromResult" to register handlers implementing this interface.
  *
- * @stable to implement
  * @ingroup Hooks
  */
 interface TitleArrayFromResultHook {
@@ -18,6 +17,7 @@ interface TitleArrayFromResultHook {
 	 * database result.
 	 *
 	 * @since 1.35
+	 * @deprecated since 1.36
 	 *
 	 * @param TitleArray &$titleArray Set this to an object to override the default object returned
 	 * @param IResultWrapper $res Database result used to create the object

includes/HookContainer/DeprecatedHooks.php

@@ -70,6 +70,7 @@ class DeprecatedHooks {
 		'SkinTemplatePreventOtherActiveTabs' => [ 'deprecatedVersion' => '1.35' ],
 		'SkinTemplateTabAction' => [ 'deprecatedVersion' => '1.35' ],
 		'SkinTemplateToolboxEnd' => [ 'deprecatedVersion' => '1.35' ],
+		'TitleArrayFromResult' => [ 'deprecatedVersion' => '1.36' ],
 		'TitleMoveComplete' => [ 'deprecatedVersion' => '1.35' ],
 		'TitleMoveCompleting' => [ 'deprecatedVersion' => '1.35' ],
 		'UndeleteShowRevision' => [ 'deprecatedVersion' => '1.35' ],