Drop the ArticleUndeleteLogEntry hook

No known uses, deprecated in I00b4b1ae89606330e0a907c25bcd40d9c797bc84

Change-Id: Icb5c3fe188a7c771de8e2b225d7ca7f677cef0ce

RELEASE-NOTES-1.38

@@ -83,6 +83,7 @@ because of Phabricator reports.
   1.35, have been removed.
 * TemplateParser used to support disabling the cache with a boolean parameter
   in its constructor. This was deprecated in 1.35 and has now been removed.
+* The ArticleUndeleteLogEntry hook, deprecated in 1.37, was removed.
 * The global function mimeTypeMatch() has been removed without a deprecation
   process.
 * The signature of PageUpdater::markAsRevert method was changed. It has never

includes/HookContainer/DeprecatedHooks.php

@@ -35,7 +35,6 @@ class DeprecatedHooks {
 	 */
 	private $deprecatedHooks = [
 		'AddNewAccount' => [ 'deprecatedVersion' => '1.27', 'silent' => true ],
-		'ArticleUndeleteLogEntry' => [ 'deprecatedVersion' => '1.37' ],
 		'BaseTemplateAfterPortlet' => [ 'deprecatedVersion' => '1.35' ],
 		'BeforeParserFetchTemplateAndtitle' => [ 'deprecatedVersion' => '1.36' ],
 		'BeforeParserrenderImageGallery' => [ 'deprecatedVersion' => '1.35' ],

includes/HookContainer/HookRunner.php

@@ -436,7 +436,6 @@ class HookRunner implements
 	\MediaWiki\Page\Hook\ArticleRevisionViewCustomHook,
 	\MediaWiki\Page\Hook\ArticleShowPatrolFooterHook,
 	\MediaWiki\Page\Hook\ArticleUndeleteHook,
-	\MediaWiki\Page\Hook\ArticleUndeleteLogEntryHook,
 	\MediaWiki\Page\Hook\ArticleViewFooterHook,
 	\MediaWiki\Page\Hook\ArticleViewHeaderHook,
 	\MediaWiki\Page\Hook\ArticleViewRedirectHook,
@@ -826,13 +825,6 @@ class HookRunner implements
 		);
 	}
 
-	public function onArticleUndeleteLogEntry( $pageArchive, &$logEntry, $user ) {
-		return $this->container->run(
-			'ArticleUndeleteLogEntry',
-			[ $pageArchive, &$logEntry, $user ]
-		);
-	}
-
 	public function onArticleUpdateBeforeRedirect( $article, &$sectionanchor,
 		&$extraq
 	) {

includes/page/Hook/ArticleUndeleteLogEntryHook.php

@@ -1,28 +0,0 @@
-<?php
-
-namespace MediaWiki\Page\Hook;
-
-use ManualLogEntry;
-use PageArchive;
-use User;
-
-/**
- * This is a hook handler interface, see docs/Hooks.md.
- * Use the hook name "ArticleUndeleteLogEntry" to register handlers implementing this interface.
- *
- * @deprecated since 1.37
- * @ingroup Hooks
- */
-interface ArticleUndeleteLogEntryHook {
-	/**
-	 * This hook is called when a log entry is generated but not yet saved.
-	 *
-	 * @since 1.35
-	 *
-	 * @param PageArchive $pageArchive
-	 * @param ManualLogEntry &$logEntry
-	 * @param User $user User who is performing the log action
-	 * @return bool|void True or no return value to continue or false to abort
-	 */
-	public function onArticleUndeleteLogEntry( $pageArchive, &$logEntry, $user );
-}

includes/page/PageArchive.php

@@ -513,9 +513,6 @@ class PageArchive {
 			],
 		] );
 
-		$legacyUser = $this->userFactory->newFromUserIdentity( $user );
-		$this->hookRunner->onArticleUndeleteLogEntry( $this, $logEntry, $legacyUser );
-
 		$logid = $logEntry->insert();
 		$logEntry->publish( $logid );