Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

(bug 29105) Splitlines completely messes up selection of inserted text. This is not a problem in practice (WikiEditor doesn't have multiline insertions with splitlines enabled since r89402), but just in case it ever becomes a problem I'm disabling selection of inserted text altogether when splitlines is enabled; instead, the cursor will be moved to the end of the inserted text.

Browse source
This commit is contained in:
Roan Kattouw 2011-06-03 10:08:06 +00:00
parent 7f043049b9
commit 35dbdb618f
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
resources/jquery/jquery.textSelection.js
View file

@ -128,12 +128,11 @@ encapsulateSelection: function( options ) {
selText = selText.replace( /\r?\n/g, "\r\n" );
post = post.replace( /\r?\n/g, "\r\n" );
}
if ( isSample && options.selectPeri ) {
if ( isSample && options.selectPeri && !options.splitlines ) {
this.selectionStart = startPos + pre.length;
this.selectionEnd = startPos + pre.length + selText.length;
} else {
this.selectionStart = startPos + pre.length + selText.length +
post.length;
this.selectionStart = startPos + insertText.length;
this.selectionEnd = this.selectionStart;
}
} else if ( document.selection && document.selection.createRange ) {
@ -413,7 +412,7 @@ scrollToCaretPosition: function( options ) {
'post': '', // Text to insert after the cursor/selection
'ownline': false, // Put the inserted text on a line of its own
'replace': false, // If there is a selection, replace it with peri instead of leaving it alone
'selectPeri': true, // Select the peri text if it was inserted (but not if there was a selection and replace==false)
'selectPeri': true, // Select the peri text if it was inserted (but not if there was a selection and replace==false, or if splitlines==true)
'splitlines': false // If multiple lines are selected, encapsulate each line individually
}, options );
break;