Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve Parser::strip() performance by delaying update of the strip state until the end of the parse. This improves performance in two ways: firstly by minimising the size of the state array in the case of large numbers of tags, and secondly by avoiding unnecessary invalidation of the FSS object, when FSS is enabled. The same function is preserved, because a placeholder from one recursion level should never find its way into the output of the same recursion level.

Browse source
This commit is contained in:
Tim Starling 2007-01-04 21:56:37 +00:00
parent 14cab769b9
commit 38eafdce8a
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
includes/Parser.php
View file

@ -537,6 +537,8 @@ class Parser
$uniq_prefix = $this->mUniqPrefix;
$commentState = new ReplacementArray;
$nowikiItems = array();
$generalItems = array();
$elements = array_merge(
array( 'nowiki', 'gallery' ),
@ -603,18 +605,22 @@ class Parser
$output = $tag;
}
// Unstrip the output, because unstrip() is no longer recursive so
// it won't do it itself
// Unstrip the output, to support recursive strip() calls
$output = $state->unstripBoth( $output );
if( !$stripcomments && $element == '!--' ) {
$commentState->setPair( $marker, $output );
} elseif ( $element == 'html' || $element == 'nowiki' ) {
$state->nowiki->setPair( $marker, $output );
$nowikiItems[$marker] = $output;
} else {
$state->general->setPair( $marker, $output );
$generalItems[$marker] = $output;
}
}
# Add the new items to the state
# We do this after the loop instead of during it to avoid slowing
# down the recursive unstrip
$state->nowiki->mergeArray( $nowikiItems );
$state->general->mergeArray( $generalItems );
# Unstrip comments unless explicitly told otherwise.
# (The comments are always stripped prior to this point, so as to