Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Check for error before outputting srcset urls

Browse source 
If $thumb returns a MediaTransformError object, then $thumb->getUrl()
will return false, which will result in srcset="1.5x, 2x".

Bug: 67081
Change-Id: Idb6bbff6995536d20dac67ce12592f68f6d1235a
This commit is contained in:
Brian Wolff 2014-06-25 21:48:16 -03:00
parent 3fd9ff66f5
commit 3f659fb963
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Linker.php
View file

@ -913,10 +913,10 @@ class Linker {
$thumb15 = $file->transform( $hp15 );
$thumb20 = $file->transform( $hp20 );
if ( $thumb15 && $thumb15->getUrl() !== $thumb->getUrl() ) {
if ( $thumb15 && !$thumb15->isError() && $thumb15->getUrl() !== $thumb->getUrl() ) {
$thumb->responsiveUrls['1.5'] = $thumb15->getUrl();
}
if ( $thumb20 && $thumb20->getUrl() !== $thumb->getUrl() ) {
if ( $thumb20 && !$thumb20->isError() && $thumb20->getUrl() !== $thumb->getUrl() ) {
$thumb->responsiveUrls['2'] = $thumb20->getUrl();
}
}