Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "ApiLoginTest: Remove testGotCookie that's been broken for 10 years"

Browse source
This commit is contained in:
jenkins-bot 2021-02-02 19:32:43 +00:00 committed by Gerrit Code Review
commit 3fbe3c626c
1 changed files with 0 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
tests/phpunit/includes/api/ApiLoginTest.php
View file

@ -255,54 +255,6 @@ class ApiLoginTest extends ApiTestCase {
] ], $ret[0] );
}
/**
* @todo Should this test just be deleted?
* @group Broken
*/
public function testGotCookie() {
$this->markTestIncomplete( "The server can't do external HTTP requests, "
. "and the internal one won't give cookies" );
global $wgServer, $wgScriptPath;
$user = self::$users['sysop'];
$userName = $user->getUser()->getName();
$password = $user->getPassword();
$req = MWHttpRequest::factory(
self::$apiUrl . '?action=login&format=json',
[
'method' => 'POST',
'postData' => [
'lgname' => $userName,
'lgpassword' => $password,
],
],
__METHOD__
);
$req->execute();
$content = json_decode( $req->getContent() );
$this->assertSame( 'NeedToken', $content->login->result );
$req->setData( [
'lgtoken' => $content->login->token,
'lgname' => $userName,
'lgpassword' => $password,
] );
$req->execute();
$cj = $req->getCookieJar();
$serverName = parse_url( $wgServer, PHP_URL_HOST );
$this->assertIsString( $serverName );
$serializedCookie = $cj->serializeToHttpRequest( $wgScriptPath, $serverName );
$this->assertRegExp(
'/_session=[^;]*; .*UserID=[0-9]*; .*UserName=' . $userName . '; .*Token=/',
$serializedCookie
);
}
/**
* @return [ $username, $password ] suitable for passing to an API request for successful login
*/