Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reverted r48983: obsolete since r48989, replaced by less intrusive optimisations.

Browse source
This commit is contained in:
Tim Starling 2009-05-04 08:57:33 +00:00
parent a091d1366f
commit 430a2a6ea6
1 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
includes/Title.php
View file

@ -1018,8 +1018,7 @@ class Title {
/**
* Can $wgUser perform $action on this page?
* This skips potentially expensive cascading permission checks
* as well as avoids expensive error formatting
* This skips potentially expensive cascading permission checks.
*
* Suitable for use for nonessential UI controls in common cases, but
* _not_ for functional access control.
@ -1204,14 +1203,8 @@ class Title {
}
} elseif( !$user->isAllowed( $action ) ) {
$return = null;
// We avoid expensive display logic for quickUserCan's and such
$groups = false;
if (!$short) {
$groups = array_map( array( 'User', 'makeGroupLinkWiki' ),
User::getGroupsWithPermission( $action ) );
}
$groups = array_map( array( 'User', 'makeGroupLinkWiki' ),
User::getGroupsWithPermission( $action ) );
if( $groups ) {
$return = array( 'badaccess-groups',
array( implode( ', ', $groups ), count( $groups ) ) );