From 43a1a61c1e643e288d59186102bb376f9bf26aee Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Wed, 27 Oct 2021 00:10:36 +0200 Subject: [PATCH] Use ParserOptions::newFromContext in MessageCache The context is already called, just reuse it. This avoids unstub of $wgLang in ParserOptions constructor Change-Id: I3ac6abf6237db7c1c09740c1fec1224779e86888 --- includes/cache/MessageCache.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/includes/cache/MessageCache.php b/includes/cache/MessageCache.php index e12f6e3490a..0af3f566c01 100644 --- a/includes/cache/MessageCache.php +++ b/includes/cache/MessageCache.php @@ -204,7 +204,8 @@ class MessageCache implements LoggerAwareInterface { */ private function getParserOptions() { if ( !$this->mParserOptions ) { - $user = RequestContext::getMain()->getUser(); + $context = RequestContext::getMain(); + $user = $context->getUser(); if ( !$user->isSafeToLoad() ) { // It isn't safe to use the context user yet, so don't try to get a // ParserOptions for it. And don't cache this ParserOptions @@ -214,7 +215,7 @@ class MessageCache implements LoggerAwareInterface { return $po; } - $this->mParserOptions = new ParserOptions( $user ); + $this->mParserOptions = ParserOptions::newFromContext( $context ); // Messages may take parameters that could come // from malicious sources. As a precaution, disable // the parser tag when parsing messages.