Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

My proposed fix to bug 34987: gender not working in many special pages.

Browse source 
I haven't checked if there are other places whereh context is set to Message class, but if there are they might need a fix too.
This commit is contained in:
Niklas Laxström 2012-03-07 10:13:58 +00:00
parent 731b8aa809
commit 455d6dae19
2 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
includes/Message.php
View file

@ -90,8 +90,7 @@
* ->plain();
* @endcode
*
* @note You cannot parse the text except in the content or interface
* @note languages
* @note You can parse the text only in the content or interface languages
*
* @section message_compare_old Comparison with old wfMsg* functions:
*
@ -341,6 +340,18 @@ class Message {
return $this;
}
/**
* Allows manipulating the interface message flag directly.
* Can be used to restore the flag after setting a language.
* @param $value bool
* @return Message: $this
* @since 1.20
*/
public function setInterfaceMessageFlag( $value ) {
$this->interface = (bool) $value;
return $this;
}
/**
* Enable or disable database use.
* @param $value Boolean

10
includes/SpecialPage.php
View file

@ -768,7 +768,15 @@ class SpecialPage {
// Works fine as the first parameter, which appears elsewhere in the
// code base. Sighhhh.
$args = func_get_args();
return call_user_func_array( array( $this->getContext(), 'msg' ), $args );
$message = call_user_func_array( array( $this->getContext(), 'msg' ), $args );
// RequestContext passes context to wfMessage, and the language is set from
// the context, but setting the language for Message class removes the
// interface message status, which breaks for example usernameless gender
// invokations. Restore the flag when not including special page in content.
if ( !$this->including() ) {
$message->setInterfaceMessageFlag( true );
}
return $message;
}
/**