Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ResourceLoader::filter: use APC when running under HHVM

Browse source 
On HHVM, (a) the cost of a ResourceLoader::filter cache miss is smaller, and
(b) APC is faster and more resilient than PHP's. These two things tilt the
scales in favor of using APC rather than Memcached.

Change-Id: I30b490e5bc815849d4b0bb06f2dbbb68825ed225
This commit is contained in:
Ori Livneh 2015-05-12 20:45:01 -07:00
parent 2b8a3f0238
commit 458e7cabbb
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
includes/resourceloader/ResourceLoader.php
View file

@ -195,9 +195,8 @@ class ResourceLoader {
if ( !$options['cache'] ) { if ( !$options['cache'] ) {
$result = $this->applyFilter( $filter, $data ); $result = $this->applyFilter( $filter, $data );
} else { } else {
// Use CACHE_ANYTHING since filtering is very slow compared to DB queries
$key = wfMemcKey( 'resourceloader', 'filter', $filter, self::$filterCacheVersion, md5( $data ) ); $key = wfMemcKey( 'resourceloader', 'filter', $filter, self::$filterCacheVersion, md5( $data ) );
$cache = wfGetCache( CACHE_ANYTHING ); $cache = wfGetCache( wfIsHHVM() ? CACHE_ACCEL : CACHE_ANYTHING );
$cacheEntry = $cache->get( $key ); $cacheEntry = $cache->get( $key );
if ( is_string( $cacheEntry ) ) { if ( is_string( $cacheEntry ) ) {
wfIncrStats( "rl-$filter-cache-hits" ); wfIncrStats( "rl-$filter-cache-hits" );