Merge "Hard deprecate ParserOutput::addWarning()"

RELEASE-NOTES-1.38

@@ -226,11 +226,11 @@ because of Phabricator reports.
    - ::setCategoryLinks()    - use ::setCategories()
    - ::addTrackingCategory() - use Parser::addTrackingCategory()
                                or TrackingCategories::addTrackingCategory()
+   - ::addWarning()          - use ::addWarningMsg()
 * The following methods from the ParserOutput class were deprecated:
    - ::getFlag() - use ::getOutputFlag()
    - ::setFlag() - use ::setOutputFlag()
    - ::getAllFlags() - this method is now marked @internal
-   - ::addWarning() - use ::addWarningMsg()
 * The following methods were deprecated; use ::setPreventClickjacking(..)
   instead:
    - OutputPage::preventClickjacking()

includes/parser/ParserOutput.php

@@ -842,6 +842,7 @@ class ParserOutput extends CacheTime {
 	 * @deprecated since 1.38; use ::addWarningMsg() instead
 	 */
 	public function addWarning( $s ) {
+		wfDeprecated( __METHOD__, '1.38' );
 		$this->mWarnings[$s] = 1;
 	}