Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

(bug 12859) Deprecate $wgRateLimitsExcludedGroups in favor of adding the 'noratelimit' user right. Doing it properly this time, so old functionality is still intact.

Browse source
This commit is contained in:
Chad Horohoe 2008-06-05 04:15:10 +00:00
parent e7c9dad7c2
commit 49f0b5bffa
3 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
RELEASE-NOTES
View file

@ -52,6 +52,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
* $wgActiveUserEditCount sets the number of edits that must be performed over
a certain number of days to be considered active
* $wgActiveUserDays is that number of days
* $wgRateLimitsExcludedGroups has been deprecated in favor of
$wgGroupPermissions[]['noratelimit']. The former still works, however.
=== New features in 1.13 ===
@ -335,6 +337,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
* (bug 14386) Fix subpage namespace oddity when moving a talk page
* (bug 11771) Signup form now not shown if in read-only mode.
* (bug 10080) Users can now modify an existing block without unblocking first.
* (bug 12859) $wgRateLimitsExcludedGroups has been deprecated in favor of
$wgGroupPermissions[]['noratelimit'].
=== API changes in 1.13 ===

10
includes/DefaultSettings.php
View file

@ -1140,10 +1140,12 @@ $wgGroupPermissions['sysop']['markbotedits'] = true;
$wgGroupPermissions['sysop']['suppressredirect'] = true;
$wgGroupPermissions['sysop']['apihighlimits'] = true;
$wgGroupPermissions['sysop']['browsearchive'] = true;
$wgGroupPermissions['sysop']['noratelimit'] = true;
#$wgGroupPermissions['sysop']['mergehistory'] = true;
// Permission to change users' group assignments
$wgGroupPermissions['bureaucrat']['userrights'] = true;
$wgGroupPermissions['bureaucrat']['noratelimit'] = true;
// Permission to change users' groups assignments across wikis
#$wgGroupPermissions['bureaucrat']['userrights-interwiki'] = true;
@ -2848,8 +2850,14 @@ $wgRateLimitLog = null;
/**
* Array of groups which should never trigger the rate limiter
*
* @deprecated as of 1.13.0, the preferred method is using
* $wgGroupPermissions[]['noratelimit']. However, this will still
* work if desired.
*
* $wgRateLimitsExcludedGroups = array( 'sysop', 'bureaucrat' );
*/
$wgRateLimitsExcludedGroups = array( 'sysop', 'bureaucrat' );
/**
* On Special:Unusedimages, consider images "used", if they are put

8
includes/User.php
View file

@ -1102,7 +1102,13 @@ class User {
*/
public function isPingLimitable() {
global $wgRateLimitsExcludedGroups;
return array_intersect($this->getEffectiveGroups(), $wgRateLimitsExcludedGroups) == array();
if ( array_intersect($this->getEffectiveGroups(), $wgRateLimitsExcludedGroups) == array() ||
!$this->isAllowed('noratelimit') ) {
return true;
}
else {
return false;
}
}
/**