Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update LinkCache::addGoodLinkObj param defaults to int

Browse source 
Update the defaults for $revision and $model from bool to int, making it
consistent with the documented input. Also update docs and line length.
Change "inval( $x )" to preferred "(int) $x" while changing the method.

Change-Id: Ic19a408aa7c50fb03e2c3aca8df3fa7cedc2420b
This commit is contained in:
Siebrand Mazeland 2013-11-17 21:42:23 +01:00
parent 81660007b8
commit 4a4fc11008
1 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
includes/cache/LinkCache.php vendored
View file

@ -123,21 +123,24 @@ class LinkCache {
/**
* Add a link for the title to the link cache
*
* @param $id Integer: page's ID
* @param $title Title object
* @param $len Integer: text's length
* @param $redir Integer: whether the page is a redirect
* @param $revision Integer: latest revision's ID
* @param $model Integer: latest revision's content model ID
* @param int $id Page's ID
* @param Title $title
* @param int $len Text's length
* @param int $redir Whether the page is a redirect
* @param int $revision Latest revision's ID
* @param int $model Latest revision's content model ID
*/
public function addGoodLinkObj( $id, $title, $len = -1, $redir = null, $revision = false, $model = false ) {
public function addGoodLinkObj( $id, $title, $len = -1, $redir = null,
$revision = 0, $model = 0
) {
$dbkey = $title->getPrefixedDBkey();
$this->mGoodLinks[$dbkey] = intval( $id );
$this->mGoodLinks[$dbkey] = (int)$id;
$this->mGoodLinkFields[$dbkey] = array(
'length' => intval( $len ),
'redirect' => intval( $redir ),
'revision' => intval( $revision ),
'model' => intval( $model ) );
'length' => (int)$len,
'redirect' => (int)$redir,
'revision' => (int)$revision,
'model' => (int)$model
);
}
/**