Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

jquery.makeCollapsible: Use .prop() for value attribute of list item

Browse source 
The issue with "value" attributes is popularised through form
fields (e.g. change <input> value with prop, because it doesn't work
with attribute, attributes only change the DOM, not the live rendering).
However the attribute/property issue isn't limited to form fields and the
typical value/selected/disabled properties . It applies to all properties
and for any element that affects active state (if it changes the display,
one should use a property, not an attribute).

As far as I know, unlike for form fields, browsers do actually synchronise
attributes in the many of those cases (including list items), so there is
no immediate danger. But since it's caught by jQuery Migrate and a good
practice regardless, change it to use prop() as well.

To test:
 https://test.wikipedia.org/?oldid=199994#head-collapsible-ol

Change-Id: I246c26bd2958209feed73fc2ef31cf678b12fa3b
This commit is contained in:
Timo Tijhof 2014-05-24 03:27:25 +02:00 committed by Krinkle
parent 23563a3c10
commit 4ba7d3c244
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/src/jquery/jquery.makeCollapsible.js
View file

@ -351,9 +351,9 @@
// Make sure the numeral order doesn't get messed up, force the first (soon to be second) item
// to be "1". Except if the value-attribute is already used.
// If no value was set WebKit returns "", Mozilla returns '-1', others return 0, null or undefined.
firstval = $firstItem.attr( 'value' );
firstval = $firstItem.prop( 'value' );
if ( firstval === undefined || !firstval || firstval === '-1' || firstval === -1 ) {
$firstItem.attr( 'value', '1' );
$firstItem.prop( 'value', '1' );
}
$toggleLink = buildDefaultToggleLink();
$toggleLink.wrap( '<li class="mw-collapsible-toggle-li"></li>' ).parent().prependTo( $collapsible );