From 4d54b4caa0df408a0867e4ca6e394a8262ddd28d Mon Sep 17 00:00:00 2001 From: Petr Pchelko Date: Fri, 1 Oct 2021 10:10:57 -0700 Subject: [PATCH] Run ParserOutput serialization tests against latest example available In ParserOutput serialization tests we have a large number of examples saved for different versions of MW. When MW version is released, but the serialization doesn't change, we stop running some serialization tests cause we can no longer find the latest example. Change-Id: I01e8e0e17e2371b2cd08d200d3a4611d814e74bb --- .../libs/serialization/SerializationTestUtils.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/phpunit/includes/libs/serialization/SerializationTestUtils.php b/tests/phpunit/includes/libs/serialization/SerializationTestUtils.php index 76bb0b5c0cc..b67f37e4927 100644 --- a/tests/phpunit/includes/libs/serialization/SerializationTestUtils.php +++ b/tests/phpunit/includes/libs/serialization/SerializationTestUtils.php @@ -207,8 +207,14 @@ class SerializationTestUtils { string $testCaseName, string $version = null ) { - $version = $version ?: $this->getCurrentVersion(); - $path = "{$this->serializedDataPath}/{$version}-{$class}-{$testCaseName}.{$this->ext}"; + if ( $version ) { + $path = "$this->serializedDataPath/$version-$class-$testCaseName.$this->ext"; + } else { + // Find the latest version we have saved. + $savedFiles = glob( "$this->serializedDataPath/?.??-$class-$testCaseName.$this->ext" ); + sort( $savedFiles ); + $path = $savedFiles[count( $savedFiles ) - 1]; + } return (object)[ 'version' => $version, 'class' => $class,