Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests: Add ActionFactoryIntegrationTest

Browse source 
Test all action specs to be valid, avoid T326275

Change-Id: I72555f892861f38b61e4ddb2e8b338c62d24f041
This commit is contained in:
Umherirrender 2023-01-05 00:06:07 +01:00
parent 4c54ef2c4a
commit 4d8cc1bfff
2 changed files with 28 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/actions/ActionFactory.php
View file

@ -132,6 +132,7 @@ class ActionFactory {
'mcrundo' => [
'class' => McrUndoAction::class,
'services' => [
// Same as for McrRestoreAction
'ReadOnlyMode',
'RevisionLookup',
'RevisionRenderer',
@ -142,6 +143,7 @@ class ActionFactory {
'mcrrestore' => [
'class' => McrRestoreAction::class,
'services' => [
// Same as for McrUndoAction
'ReadOnlyMode',
'RevisionLookup',
'RevisionRenderer',

26
tests/phpunit/includes/actions/ActionFactoryIntegrationTest.php Normal file
View file

@ -0,0 +1,26 @@
<?php
use MediaWiki\Actions\ActionFactory;
use MediaWiki\MediaWikiServices;
/**
* Test that runs against all core actions to make sure that
* creating an instance of the action works
*
* @coversNothing
*/
class ActionFactoryIntegrationTest extends MediaWikiIntegrationTestCase {
public function testActionFactoryServiceWiring() {
$services = MediaWikiServices::getInstance();
$actionFactory = $services->getActionFactory();
$context = RequestContext::getMain();
$article = Article::newFromTitle( Title::makeTitle( NS_MAIN, 'ActionFactoryServiceWiringTest' ), $context );
$actionSpecs = ( new ReflectionClassConstant( ActionFactory::class, 'CORE_ACTIONS' ) )->getValue();
foreach ( $actionSpecs as $action => $_ ) {
$this->assertInstanceOf( Action::class, $actionFactory->getAction( $action, $article, $context ) );
}
}
}