Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make the context page the edited page in EditPages

Browse source 
This forces the WikiPage returned by $this->getContext()->getPage()
to be the same as $this->page.

This seems to be redundant at the moment, but it seems prudent to
make sure this does not break. Having two WikiPage instances may
cause subtle problems, such as redundant parsing of content during
edits.

Bug: T205369
Change-Id: I8dd3235ec395fa8772ad810f8b09a098a940ab0c
This commit is contained in:
daniel 2018-11-15 15:56:57 +01:00 committed by Daniel Kinzler
parent 595640d90d
commit 501bb93e3e
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/EditPage.php
View file

@ -476,7 +476,15 @@ class EditPage {
$this->mArticle = $article;
$this->page = $article->getPage(); // model object
$this->mTitle = $article->getTitle();
$this->context = $article->getContext();
// Make sure the local context is in sync with other member variables.
// Particularly make sure everything is using the same WikiPage instance.
// This should probably be the case in Article as well, but it's
// particularly important for EditPage, to make use of the in-place caching
// facility in WikiPage::prepareContentForEdit.
$this->context = new DerivativeContext( $article->getContext() );
$this->context->setWikiPage( $this->page );
$this->context->setTitle( $this->mTitle );
$this->contentModel = $this->mTitle->getContentModel();