Fix for r51667: external diff is also controlled by $wgUseExternalEditor (see includes/diff/DifferenceEngine.php line 107). $wgExternalDiffEngine is used to change the difference engine's backend (wikidiff, wikidiff2, ...) and not to allow users to have their own difference engine.
This commit is contained in:
parent
b6acef6319
commit
54ebc9c590
1 changed files with 4 additions and 7 deletions
|
|
@ -574,6 +574,8 @@ class Preferences {
|
|||
}
|
||||
|
||||
static function editingPreferences( $user, &$defaultPreferences ) {
|
||||
global $wgUseExternalEditor;
|
||||
|
||||
## Editing #####################################
|
||||
$defaultPreferences['cols'] =
|
||||
array(
|
||||
|
|
@ -640,19 +642,14 @@ class Preferences {
|
|||
'label-message' => 'tog-minordefault',
|
||||
);
|
||||
|
||||
global $wgUseExternalEditor;
|
||||
if ($wgUseExternalEditor) {
|
||||
if ( $wgUseExternalEditor ) {
|
||||
$defaultPreferences['externaleditor'] =
|
||||
array(
|
||||
'type' => 'toggle',
|
||||
'section' => 'editing/advancedediting',
|
||||
'label-message' => 'tog-externaleditor',
|
||||
);
|
||||
}
|
||||
|
||||
global $wgExternalDiffEngine;
|
||||
if ($wgExternalDiffEngine) {
|
||||
$defaultPreferences['externaldiff'] =
|
||||
$defaultPreferences['externaldiff'] =
|
||||
array(
|
||||
'type' => 'toggle',
|
||||
'section' => 'editing/advancedediting',
|
||||
|
|
|
|||
Loading…
Reference in a new issue