More mediawiki.js cleanup

- Convert prototype object modifications into object literal. Saves bandwidth (less characters) and speeds up execution (no need to access 2 level deep object member repetitively). Local testing (Chrome Web Inspector) shows 14.80KB to 14.67KB (non-cached, debug=false), and execution time on cached request 32ms to 25ms.
- Un-indent 1 tab for d.setTime (Follows up r92964)
- Whitespace consistency
- Move var statements to top of loader's addScript

Follows up: r92933

resources/mediawiki/mediawiki.js

@@ -29,6 +29,7 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 		return this;
 	}
 
+	Map.prototype = {
 		/**
 		 * Get the value of one or multiple a keys.
 		 *
@@ -42,7 +43,7 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 		 *  objects are always passed by reference in JavaScript!).
 		 * @return Values as a string or object, null if invalid/inexistant.
 		 */
-	Map.prototype.get = function( selection, fallback ) {
+		get: function( selection, fallback ) {
 			if ( $.isArray( selection ) ) {
 				selection = $.makeArray( selection );
 				var results = {};
@@ -64,7 +65,7 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 			} else {
 				return null; // invalid selection key
 			}
-	};
+		},
 
 		/**
 		 * Sets one or multiple key/value pairs.
@@ -73,7 +74,7 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 		 * @param value mixed Value to set (optional, only in use when key is a string)
 		 * @return bool This returns true on success, false on failure.
 		 */
-	Map.prototype.set = function( selection, value ) {
+		set: function( selection, value ) {
 			if ( $.isPlainObject( selection ) ) {
 				for ( var s in selection ) {
 					this.values[s] = selection[s];
@@ -84,7 +85,7 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 				return true;
 			}
 			return false;
-	};
+		},
 
 		/**
 		 * Checks if one or multiple keys exist.
@@ -92,7 +93,7 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 		 * @param selection mixed String key or array of keys to check
 		 * @return boolean Existence of key(s)
 		 */
-	Map.prototype.exists = function( selection ) {
+		exists: function( selection ) {
 			if ( typeof selection === 'object' ) {
 				for ( var s = 0; s < selection.length; s++ ) {
 					if ( !( selection[s] in this.values ) ) {
@@ -103,6 +104,7 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 			} else {
 				return selection in this.values;
 			}
+		}
 	};
 
 	/**
@@ -124,25 +126,26 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 		return this;
 	}
 
+	Message.prototype = {
 		/**
 		 * Appends (does not replace) parameters for replacement to the .parameters property.
 		 *
 		 * @param parameters Array
 		 * @return Message
 		 */
-	Message.prototype.params = function( parameters ) {
+		params: function( parameters ) {
 			for ( var i = 0; i < parameters.length; i++ ) {
 				this.parameters.push( parameters[i] );
 			}
 			return this;
-	};
+		},
 
 		/**
 		 * Converts message object to it's string form based on the state of format.
 		 *
 		 * @return string Message as a string in the current form or <key> if key does not exist.
 		 */
-	Message.prototype.toString = function() {
+		toString: function() {
 			if ( !this.map.exists( this.key ) ) {
 				// Return <key> if key does not exist
 				return '<' + this.key + '>';
@@ -170,45 +173,46 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 			}
 			*/
 			return text;
-	};
+		},
 
 		/**
 		 * Changes format to parse and converts message to string
 		 *
 		 * @return {string} String form of parsed message
 		 */
-	Message.prototype.parse = function() {
+		parse: function() {
 			this.format = 'parse';
 			return this.toString();
-	};
+		},
 
 		/**
 		 * Changes format to plain and converts message to string
 		 *
 		 * @return {string} String form of plain message
 		 */
-	Message.prototype.plain = function() {
+		plain: function() {
 			this.format = 'plain';
 			return this.toString();
-	};
+		},
 
 		/**
 		 * Changes the format to html escaped and converts message to string
 		 *
 		 * @return {string} String form of html escaped message
 		 */
-	Message.prototype.escaped = function() {
+		escaped: function() {
 			this.format = 'escaped';
 			return this.toString();
-	};
+		},
 
 		/**
 		 * Checks if message exists
 		 *
 		 * @return {string} String form of parsed message
 		 */
-	Message.prototype.exists = function() {
+		exists: function() {
 			return this.map.exists( this.key );
+		}
 	};
 
 	/* Public Members */
@@ -501,11 +505,10 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 							} ) );
 						}
 					} else if ( typeof style === 'string' ) {
-						getMarker().before( mw.html.element(
+						getMarker().before( mw.html.element( 'style', {
-							'style',
+							'type': 'text/css',
-							{ 'type': 'text/css', 'media': media },
+							'media': media
-							new mw.html.Cdata( style )
+						}, new mw.html.Cdata( style ) ) );
-						) );
 					}
 				}
 			}
@@ -673,11 +676,11 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 		 * @param callback Function: Optional callback which will be run when the script is done
 		 */
 		function addScript( src, callback ) {
+			var done = false, script;
 			if ( ready ) {
 				// jQuery's getScript method is NOT better than doing this the old-fassioned way
 				// because jQuery will eval the script's code, and errors will not have sane
 				// line numbers.
-				var	done = false,
 				script = document.createElement( 'script' );
 				script.setAttribute( 'src', src );
 				script.setAttribute( 'type', 'text/javascript' );
@@ -1163,8 +1166,7 @@ window.mw = window.mediaWiki = new ( function( $ ) {
 // Alias $j to jQuery for backwards compatibility
 window.$j = jQuery;
 
-/* Auto-register from pre-loaded startup scripts */
+// Auto-register from pre-loaded startup scripts
-
 if ( jQuery.isFunction( startUp ) ) {
 	startUp();
 	delete startUp;