Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed User::getGroups(), apparently broken since r33333. User::load() doesn't load groups anymore, so calling $this->getGroups() was the same as just accessing $this->mGroups. Usually it doesn't matter, since most factory functions are funnelled into loadFromId() which calls loadGroups() or loads the groups from the cache, but loadFromRow() was potentially broken.

Browse source 
It's necessary for User::loadFromRow() to set $this->mGroups to null, same as the calling code in User::loadFromDatabase(), so that they will be loaded dynamically when User::newFromRow() is called.

No bugs found that are caused by this but it couldn't hurt to have working accessors. Tested from eval.php.
This commit is contained in:
Tim Starling 2011-09-22 06:17:26 +00:00
parent 88bdda41b1
commit 59623dc0d1
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
includes/User.php
View file

@ -1053,6 +1053,8 @@ class User {
public function loadFromRow( $row ) {
$all = true;
$this->mGroups = null; // deferred
if ( isset( $row->user_name ) ) {
$this->mName = $row->user_name;
$this->mFrom = 'name';
@ -2312,6 +2314,7 @@ class User {
*/
public function getGroups() {
$this->load();
$this->loadGroups();
return $this->mGroups;
}