* (bug 24166) API error when using rvprop=tags

Move addition of revision table to after other joins
This commit is contained in:
Sam Reed 2010-09-01 16:47:21 +00:00
parent 2e4627d332
commit 5b23cea5c7
2 changed files with 5 additions and 1 deletions

View file

@ -376,6 +376,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
* For required string parameters, if '' is provided, this is now classed as
missing
* (bug 24724) list=allusers is out by 1 (shows total users - 1)
* (bug 24166) API error when using rvprop=tags
=== Languages updated in 1.17 ===

View file

@ -136,7 +136,7 @@ class ApiQueryRevisions extends ApiQueryBase {
}
$db = $this->getDB();
$this->addTables( array( 'page', 'revision' ) );
$this->addTables( 'page' );
$this->addFields( Revision::selectFields() );
$this->addWhere( 'page_id = rev_page' );
@ -202,6 +202,9 @@ class ApiQueryRevisions extends ApiQueryBase {
}
}
//Bug 24166 - API error when using rvprop=tags
$this->addTables( 'revision' );
$userMax = ( $this->fld_content ? ApiBase::LIMIT_SML1 : ApiBase::LIMIT_BIG1 );
$botMax = ( $this->fld_content ? ApiBase::LIMIT_SML2 : ApiBase::LIMIT_BIG2 );
$limit = $params['limit'];