Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests: Remove problematic (bool) casts from UserTest

Browse source 
The return value should never be anything but an actual boolean value.

Change-Id: Icaef4f7c41146c9cf401788e59af4e984c3fde49
This commit is contained in:
Thiemo Kreuz 2019-09-30 16:14:56 +02:00 committed by Umherirrender
parent 4ada35bbea
commit 5b7dd14725
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/phpunit/includes/user/UserTest.php
View file

@ -1201,7 +1201,7 @@ class UserTest extends MediaWikiTestCase {
$this->assertNull( $user->getBlock( false ), 'sanity check' );
$this->assertSame( '', $user->blockedBy(), 'sanity check' );
$this->assertSame( '', $user->blockedFor(), 'sanity check' );
$this->assertFalse( (bool)$user->isHidden(), 'sanity check' );
$this->assertFalse( $user->isHidden(), 'sanity check' );
$this->assertFalse( $user->isBlockedFrom( $ut ), 'sanity check' );
// Block the user
@ -1221,7 +1221,7 @@ class UserTest extends MediaWikiTestCase {
$this->assertInstanceOf( DatabaseBlock::class, $user->getBlock( false ) );
$this->assertSame( $blocker->getName(), $user->blockedBy() );
$this->assertSame( 'Because', $user->blockedFor() );
$this->assertTrue( (bool)$user->isHidden() );
$this->assertTrue( $user->isHidden() );
$this->assertTrue( $user->isBlockedFrom( $ut ) );
// Unblock
@ -1232,7 +1232,7 @@ class UserTest extends MediaWikiTestCase {
$this->assertNull( $user->getBlock( false ) );
$this->assertSame( '', $user->blockedBy() );
$this->assertSame( '', $user->blockedFor() );
$this->assertFalse( (bool)$user->isHidden() );
$this->assertFalse( $user->isHidden() );
$this->assertFalse( $user->isBlockedFrom( $ut ) );
}