From 5b7dd14725b79edf36e66f4a696dcf88be0e4cb1 Mon Sep 17 00:00:00 2001
From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Mon, 30 Sep 2019 16:14:56 +0200
Subject: [PATCH] tests: Remove problematic (bool) casts from UserTest

The return value should never be anything but an actual boolean value.

Change-Id: Icaef4f7c41146c9cf401788e59af4e984c3fde49
---
 tests/phpunit/includes/user/UserTest.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/phpunit/includes/user/UserTest.php b/tests/phpunit/includes/user/UserTest.php
index 9bfac16c4c8..beec9946282 100644
--- a/tests/phpunit/includes/user/UserTest.php
+++ b/tests/phpunit/includes/user/UserTest.php
@@ -1201,7 +1201,7 @@ class UserTest extends MediaWikiTestCase {
 		$this->assertNull( $user->getBlock( false ), 'sanity check' );
 		$this->assertSame( '', $user->blockedBy(), 'sanity check' );
 		$this->assertSame( '', $user->blockedFor(), 'sanity check' );
-		$this->assertFalse( (bool)$user->isHidden(), 'sanity check' );
+		$this->assertFalse( $user->isHidden(), 'sanity check' );
 		$this->assertFalse( $user->isBlockedFrom( $ut ), 'sanity check' );
 
 		// Block the user
@@ -1221,7 +1221,7 @@ class UserTest extends MediaWikiTestCase {
 		$this->assertInstanceOf( DatabaseBlock::class, $user->getBlock( false ) );
 		$this->assertSame( $blocker->getName(), $user->blockedBy() );
 		$this->assertSame( 'Because', $user->blockedFor() );
-		$this->assertTrue( (bool)$user->isHidden() );
+		$this->assertTrue( $user->isHidden() );
 		$this->assertTrue( $user->isBlockedFrom( $ut ) );
 
 		// Unblock
@@ -1232,7 +1232,7 @@ class UserTest extends MediaWikiTestCase {
 		$this->assertNull( $user->getBlock( false ) );
 		$this->assertSame( '', $user->blockedBy() );
 		$this->assertSame( '', $user->blockedFor() );
-		$this->assertFalse( (bool)$user->isHidden() );
+		$this->assertFalse( $user->isHidden() );
 		$this->assertFalse( $user->isBlockedFrom( $ut ) );
 	}