Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move around User::getEditCount() code.

Browse source 
It's simpler to do an early return and catch almost everything
in the profiling.

Change-Id: I2306c7b39d9808989f11d7d9d34db06c39d51820
This commit is contained in:
Platonides 2012-11-26 22:56:42 +01:00
parent 720a682425
commit 5e309c21b4
1 changed files with 21 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
includes/User.php
View file

@ -2454,30 +2454,29 @@ class User {
* @return Int
*/
public function getEditCount() {
if( $this->getId() ) {
if ( !isset( $this->mEditCount ) ) {
/* Populate the count, if it has not been populated yet */
wfProfileIn( __METHOD__ );
$dbr = wfGetDB( DB_SLAVE );
// check if the user_editcount field has been initialized
$count = $dbr->selectField(
'user', 'user_editcount',
array( 'user_id' => $this->mId ),
__METHOD__
);
if( $count === null ) {
// it has not been initialized. do so.
$count = $this->initEditCount();
}
wfProfileOut( __METHOD__ );
$this->mEditCount = intval( $count );
}
return $this->mEditCount;
} else {
/* nil */
if ( !$this->getId() ) {
return null;
}
if ( !isset( $this->mEditCount ) ) {
/* Populate the count, if it has not been populated yet */
wfProfileIn( __METHOD__ );
$dbr = wfGetDB( DB_SLAVE );
// check if the user_editcount field has been initialized
$count = $dbr->selectField(
'user', 'user_editcount',
array( 'user_id' => $this->mId ),
__METHOD__
);
if( $count === null ) {
// it has not been initialized. do so.
$count = $this->initEditCount();
}
$this->mEditCount = intval( $count );
wfProfileOut( __METHOD__ );
}
return $this->mEditCount;
}
/**