Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove meaningless constructor tests

Browse source 
These tests do effectively only one thing: Test if the constructor
succeeds without throwing an exception. But these constructors are
all trivial and can't even do that. They are still covered by all
the other tests that also involve the constructor.

Change-Id: I206da47fd93a8ecbb08271390ecc1307ffe9df4e
This commit is contained in:
thiemowmde 2024-05-06 09:58:55 +02:00
parent 7efb44284e
commit 62a94f4d24
3 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tests/phpunit/includes/mail/MailAddressTest.php
View file

@ -7,13 +7,6 @@ class MailAddressTest extends MediaWikiIntegrationTestCase {
/**
* @covers \MailAddress::__construct
*/
public function testConstructor() {
$ma = new MailAddress( 'foo@bar.baz', 'UserName', 'Real name' );
$this->assertInstanceOf( MailAddress::class, $ma );
}
/**
* @covers \MailAddress::newFromUser
*/
public function testNewFromUser() {

6
tests/phpunit/unit/includes/ResourceLoader/FilePathTest.php
View file

@ -12,12 +12,6 @@ use RuntimeException;
*/
class FilePathTest extends MediaWikiUnitTestCase {
public function testConstructor() {
$path = new FilePath( 'dummy/path', '/local', '/remote' );
$this->assertInstanceOf( FilePath::class, $path );
}
public function testGetterSimple() {
$path = new FilePath( 'dummy/path', '/local', '/remote' );

5
tests/phpunit/unit/includes/content/Renderer/ContentRendererTest.php
View file

@ -48,11 +48,6 @@ class ContentRendererTest extends MediaWikiUnitTestCase {
$this->globalIdGenerator = $this->createMock( GlobalIdGenerator::class );
}
public function testConstructor() {
$renderer = new ContentRenderer( $this->contentHandlerFactory, $this->globalIdGenerator );
$this->assertInstanceOf( ContentRenderer::class, $renderer );
}
/**
* This method tests the getParserOutput method. It is expected that the method will return a ParserOutput
* object with a render ID, cache revision ID, and revision timestamp.