Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Remove unused MediaWikiTestCase::prepareConnectionForTesting"

Browse source
This commit is contained in:
jenkins-bot 2018-09-13 09:40:18 +00:00 committed by Gerrit Code Review
commit 66351c7f1b
1 changed files with 0 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
tests/phpunit/MediaWikiTestCase.php
View file

@ -1288,52 +1288,6 @@ abstract class MediaWikiTestCase extends PHPUnit\Framework\TestCase {
self::$dbSetup = false;
}
/**
* Prepares the given database connection for usage in the context of usage tests.
* This sets up clones database tables and changes the table prefix as appropriate.
* If the database connection already has cloned tables, calling this method has no
* effect. The tables are not re-cloned or reset in that case.
*
* @param IMaintainableDatabase $db
*/
protected function prepareConnectionForTesting( IMaintainableDatabase $db ) {
if ( !self::$dbSetup ) {
throw new LogicException(
'Cannot use prepareConnectionForTesting()'
. ' if the test case is not defined to use the database!'
);
}
if ( isset( $db->_originalTablePrefix ) ) {
// The DB connection was already prepared for testing.
return;
}
$testPrefix = self::getTestPrefixFor( $db );
$oldPrefix = $db->tablePrefix();
$tablesCloned = self::listTables( $db );
if ( $oldPrefix === $testPrefix ) {
// The database connection already has the test prefix, but presumably not
// the cloned tables. This is the typical case, since the LBFactory will
// have the prefix set during testing, but LoadBalancers will still return
// connections that don't have the cloned table structure.
$oldPrefix = self::$oldTablePrefix;
}
$dbClone = new CloneDatabase( $db, $tablesCloned, $testPrefix, $oldPrefix );
$dbClone->useTemporaryTables( self::$useTemporaryTables );
$db->_originalTablePrefix = $oldPrefix;
if ( ( $db->getType() == 'oracle' || !self::$useTemporaryTables ) && self::$reuseDB ) {
throw new LogicException( 'Cannot clone database tables' );
} else {
$dbClone->cloneTableStructure();
}
}
/**
* Setups a database with cloned tables using the given prefix.
*