Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add lowercase variants to the autoloader for legacy history blob classes

Browse source 
Blobs in the text table created by MediaWiki <1.5 running on PHP 4 had class
names coerced to lowercase. In order to succcessfully resolve these class
names, the autoloader creates a copy of the autoload class array with
lowercased keys, which is pretty inefficient. So instead, make sure the
auto-generated autoload map contains lowercase variants for these specific
classes.

Bug: T166759
Change-Id: I6d751ef516e936e04c056d70a1ecd17960a39ceb
This commit is contained in:
Ori Livneh 2017-10-14 16:57:38 -04:00 committed by Krinkle
parent 96a512667a
commit 692cf27013
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
autoload.php
View file

@ -1706,5 +1706,8 @@ $wgAutoloadLocalClasses = [
'ZhConverter' => __DIR__ . '/languages/classes/LanguageZh.php',
'ZipDirectoryReader' => __DIR__ . '/includes/utils/ZipDirectoryReader.php',
'ZipDirectoryReaderError' => __DIR__ . '/includes/utils/ZipDirectoryReaderError.php',
'concatenatedgziphistoryblob' => __DIR__ . '/includes/HistoryBlob.php',
'historyblobcurstub' => __DIR__ . '/includes/HistoryBlob.php',
'historyblobstub' => __DIR__ . '/includes/HistoryBlob.php',
'profile_point' => __DIR__ . '/profileinfo.php',
];

13
includes/HistoryBlob.php
View file

@ -699,3 +699,16 @@ class DiffHistoryBlob implements HistoryBlob {
}
}
// @codingStandardsIgnoreStart
if ( false ) {
// Blobs generated by MediaWiki < 1.5 on PHP 4 were serialized with the
// class name coerced to lowercase. We can improve efficiency by adding
// autoload entries for the lowercase variants of these classes (T166759).
// The code below is never executed, but it is picked up by the AutoloadGenerator
// parser, which scans for class_alias() calls.
class_alias( 'ConcatenatedGzipHistoryBlob', 'concatenatedgziphistoryblob' );
class_alias( 'HistoryBlobCurStub', 'historyblobcurstub' );
class_alias( 'HistoryBlobStub', 'historyblobstub' );
}
// @codingStandardsIgnoreEnd