Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove old Title CSS/JS methods, deprecated in 1.31, unused

Browse source 
Change-Id: I500b5efbdc2ee3b4ca09662ed0df89e9d7514bbd
This commit is contained in:
James D. Forrester 2019-02-07 17:03:39 -08:00
parent 9e82d41221
commit 69eb43708d
2 changed files with 7 additions and 49 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
RELEASE-NOTES-1.33
View file

@ -197,6 +197,13 @@ because of Phabricator reports.
Sanitizer::escapeIdForLink() or escapeIdForExternalInterwiki() instead.
* Title->canTalk(), deprecated in 1.30, was removed. Instead, use
Title->canHaveTalkPage().
* Title's methods for site and user page related to CSS and JS, deprecated in
1.31, were removed:
* Title->isCssOrJsPage() — Use Title->isSiteConfigPage()
* Title->isCssJsSubpage() – Use Title->isUserConfigPage()
* Title->getSkinFromCssJsSubpage() – Use Title->getSkinFromConfigSubpage()
* Title->isCssSubpage() – Use Title->isUserCssConfigPage()
* Title->isJsSubpage() – Use Title->isUserJsConfigPage()
=== Deprecations in 1.33 ===
* The configuration option $wgUseESI has been deprecated, and is expected

49
includes/Title.php
View file

@ -1280,17 +1280,6 @@ class Title implements LinkTarget, IDBAccessObject {
);
}
/**
* @return bool
* @deprecated Since 1.31; use ::isSiteConfigPage() instead (which also checks for JSON pages)
*/
public function isCssOrJsPage() {
wfDeprecated( __METHOD__, '1.31' );
return ( NS_MEDIAWIKI == $this->mNamespace
&& ( $this->hasContentModel( CONTENT_MODEL_CSS )
|| $this->hasContentModel( CONTENT_MODEL_JAVASCRIPT ) ) );
}
/**
* Is this a "config" (.css, .json, or .js) sub-page of a user page?
*
@ -1305,17 +1294,6 @@ class Title implements LinkTarget, IDBAccessObject {
);
}
/**
* @return bool
* @deprecated Since 1.31; use ::isUserConfigPage() instead (which also checks for JSON pages)
*/
public function isCssJsSubpage() {
wfDeprecated( __METHOD__, '1.31' );
return ( NS_USER == $this->mNamespace && $this->isSubpage()
&& ( $this->hasContentModel( CONTENT_MODEL_CSS )
|| $this->hasContentModel( CONTENT_MODEL_JAVASCRIPT ) ) );
}
/**
* Trim down a .css, .json, or .js subpage title to get the corresponding skin name
*
@ -1332,15 +1310,6 @@ class Title implements LinkTarget, IDBAccessObject {
return substr( $subpage, 0, $lastdot );
}
/**
* @deprecated Since 1.31; use ::getSkinFromConfigSubpage() instead
* @return string Containing skin name from .css, .json, or .js subpage title
*/
public function getSkinFromCssJsSubpage() {
wfDeprecated( __METHOD__, '1.31' );
return $this->getSkinFromConfigSubpage();
}
/**
* Is this a CSS "config" sub-page of a user page?
*
@ -1355,15 +1324,6 @@ class Title implements LinkTarget, IDBAccessObject {
);
}
/**
* @deprecated Since 1.31; use ::isUserCssConfigPage()
* @return bool
*/
public function isCssSubpage() {
wfDeprecated( __METHOD__, '1.31' );
return $this->isUserCssConfigPage();
}
/**
* Is this a JSON "config" sub-page of a user page?
*
@ -1392,15 +1352,6 @@ class Title implements LinkTarget, IDBAccessObject {
);
}
/**
* @deprecated Since 1.31; use ::isUserJsConfigPage()
* @return bool
*/
public function isJsSubpage() {
wfDeprecated( __METHOD__, '1.31' );
return $this->isUserJsConfigPage();
}
/**
* Is this a sitewide CSS "config" page?
*