Deprecate the ArticleEditUpdatesDeleteFromRecentchanges hook

Bug: T244613
Change-Id: I2bb1645a8b5d99a5a3c4425f2bc0e8c3f524d4e8

RELEASE-NOTES-1.35

@@ -445,6 +445,8 @@ because of Phabricator reports.
   - mVarSeparatorPattern
   changed from public to protected:
   - mTables
+* The ArticleEditUpdatesDeleteFromRecentchanges hook has been deprecated. Please
+  use the RecentChange_save hook or similar instead.
 * …
 
 === Other changes in 1.35 ===

docs/hooks.txt

@@ -648,7 +648,8 @@ article has been changed.
   that page after the change
 $changed: bool for if the page was changed
 
-'ArticleEditUpdatesDeleteFromRecentchanges': Before deleting old entries from
+'ArticleEditUpdatesDeleteFromRecentchanges': DEPRECATED since 1.35, use RecentChange_save
+or similar instead. Before deleting old entries from
 recentchanges table, return false to not delete old entries.
 &$wikiPage: WikiPage (object) being modified
 

includes/Storage/DerivedPageDataUpdater.php

@@ -1488,7 +1488,7 @@ class DerivedPageDataUpdater implements IDBAccessObject, LoggerAwareInterface {
 			[ &$wikiPage, &$editInfo, $this->options['changed'] ] );
 
 		// TODO: replace legacy hook! Use a listener on PageEventEmitter instead!
-		if ( Hooks::run( 'ArticleEditUpdatesDeleteFromRecentchanges', [ &$wikiPage ] ) ) {
+		if ( Hooks::run( 'ArticleEditUpdatesDeleteFromRecentchanges', [ &$wikiPage ], '1.35' ) ) {
 			// Flush old entries from the `recentchanges` table
 			if ( mt_rand( 0, 9 ) == 0 ) {
 				$this->jobQueueGroup->lazyPush( RecentChangesUpdateJob::newPurgeJob() );