Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Deprecate wfErrorLog

Browse source 
When a logging service other than MWLoggerLegacySpi is used, the
behavior of wfErrorLog is not guaranteed.

Change-Id: I8543bfd556aa752665f7a3daa855d3c2f7fc8956
This commit is contained in:
Bryan Davis 2014-12-15 16:12:57 -07:00
parent dad7abd9ce
commit 6a8c686c7a
3 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
api.php
View file

@ -122,7 +122,7 @@ if ( $wgAPIRequestLog ) {
} else {
$items[] = "failed in ApiBeforeMain";
}
wfErrorLog( implode( ',', $items ) . "\n", $wgAPIRequestLog );
MWLoggerLegacyLogger::emit( implode( ',', $items ) . "\n", $wgAPIRequestLog );
wfDebug( "Logged API request to $wgAPIRequestLog\n" );
}

2
includes/GlobalFunctions.php
View file

@ -1177,8 +1177,10 @@ function wfLogWarning( $msg, $callerOffset = 1, $level = E_USER_WARNING ) {
* @param string $file Filename
* @param array $context Additional logging context data
* @throws MWException
* @deprecated since 1.25 Use MWLoggerLegacyLogger::emit or UDPTransport
*/
function wfErrorLog( $text, $file, array $context = array() ) {
wfDeprecated( __METHOD__, '1.25' );
$logger = MWLogger::getInstance( 'wfErrorLog' );
$context['destination'] = $file;
$logger->info( trim( $text ), $context );

2
maintenance/storage/recompressTracked.php
View file

@ -141,7 +141,7 @@ class RecompressTracked {
$header .= "({$this->slaveId})";
}
$header .= ' ' . wfWikiID();
wfErrorLog( sprintf( "%-50s %s\n", $header, $msg ), $file );
MWLoggerLegacyLogger::emit( sprintf( "%-50s %s\n", $header, $msg ), $file );
}
/**