Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make use of native array_column() function where possible

Browse source 
Change-Id: I78108e7dc5a10d892e97b0101c1b72cb8d363e97
This commit is contained in:
Thiemo Kreuz 2020-10-27 18:31:39 +01:00 committed by Umherirrender
parent 89e454c7fe
commit 6f901ef17c
4 changed files with 5 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/api/ApiUpload.php
View file

@ -724,10 +724,7 @@ class ApiUpload extends ApiBase {
ApiResult::setIndexedTagName( $warnings, 'warning' );
if ( isset( $warnings['duplicate'] ) ) {
$dupes = [];
foreach ( $warnings['duplicate'] as $dupe ) {
$dupes[] = $dupe['fileName'];
}
$dupes = array_column( $warnings['duplicate'], 'fileName' );
ApiResult::setIndexedTagName( $dupes, 'duplicate' );
$warnings['duplicate'] = $dupes;
}

6
includes/deferred/LinksUpdate.php
View file

@ -1168,11 +1168,7 @@ class LinksUpdate extends DataUpdate {
if ( $this->externalLinkInsertions === null ) {
return null;
}
$result = [];
foreach ( $this->externalLinkInsertions as $key => $value ) {
$result[] = $value['el_to'];
}
return $result;
return array_column( $this->externalLinkInsertions, 'el_to' );
}
/**

11
maintenance/namespaceDupes.php
View file

@ -243,18 +243,11 @@ class NamespaceDupes extends Maintenance {
}
/**
* Get the interwiki list
*
* @return array
* @return string[]
*/
private function getInterwikiList() {
$result = MediaWikiServices::getInstance()->getInterwikiLookup()->getAllPrefixes();
$prefixes = [];
foreach ( $result as $row ) {
$prefixes[] = $row['iw_prefix'];
}
return $prefixes;
return array_column( $result, 'iw_prefix' );
}
/**

5
tests/phpunit/includes/api/query/ApiQuerySearchTest.php
View file

@ -41,10 +41,7 @@ class ApiQuerySearchTest extends ApiTestCase {
'list' => 'search',
'srsearch' => 'my query',
] );
$titles = [];
foreach ( $response['query']['search'] as $result ) {
$titles[] = $result['title'];
}
$titles = array_column( $response['query']['search'], 'title' );
$this->assertEquals( $expect, $titles );
}