Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

maintenance: Fix sql for touched-only option of refreshLinks script

Browse source 
The convert from raw sql to expression in 81c6df6a46
has a error for the touched condition.
Switch the conditions and use RawSQLExpression to use the raw sql.

Follow-Up: Ieb229d8088cb1ff3f03e44f7ac99eb612f48bc7b
Change-Id: I8fbe0ec44d1a43795a3e4c94f910e09878eebde6
(cherry picked from commit f11b59de58bcb241fa337bbcdd276d25bc94e462)
This commit is contained in:
Umherirrender 2025-07-30 23:40:47 +02:00 committed by Func
parent f4e70dc71e
commit 7508435ecc
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
maintenance/refreshLinks.php
View file

@ -26,6 +26,7 @@ use MediaWiki\Revision\RevisionRecord;
use MediaWiki\Title\Title; use MediaWiki\Title\Title;
use Wikimedia\Rdbms\IExpression; use Wikimedia\Rdbms\IExpression;
use Wikimedia\Rdbms\IReadableDatabase; use Wikimedia\Rdbms\IReadableDatabase;
use Wikimedia\Rdbms\RawSQLExpression;
use Wikimedia\Rdbms\SelectQueryBuilder; use Wikimedia\Rdbms\SelectQueryBuilder;
// @codeCoverageIgnoreStart // @codeCoverageIgnoreStart
@ -112,8 +113,8 @@ class RefreshLinks extends Maintenance {
} else { } else {
if ( $touched ) { if ( $touched ) {
$builder->andWhere( [ $builder->andWhere( [
$dbr->expr( 'page_touched', '>', 'page_links_updated' ) $dbr->expr( 'page_links_updated', '=', null )
->or( 'page_links_updated', '=', null ), ->orExpr( new RawSQLExpression( 'page_touched > page_links_updated' ) ),
] ); ] );
} }
$this->output( "Refreshing $what from pages...\n" ); $this->output( "Refreshing $what from pages...\n" );