Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ResourceLoader: Define targets in a single location

Browse source 
All the *Module classes end up inheriting from ResourceLoader/Module, so
we only need to define the targets there.

Bug: T127268
Bug: T328497
Change-Id: I12b126377cea78b88269e6efe68f92f3586c4ecc
This commit is contained in:
Kosta Harlan 2023-02-01 11:59:26 +01:00 committed by Bartosz Dziewoński
parent 95ee25aefb
commit 78916de4aa
9 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
includes/ResourceLoader/ImageModule.php
View file

@ -56,7 +56,6 @@ class ImageModule extends Module {
protected $prefix = null;
protected $selectorWithoutVariant = '.{prefix}-{name}';
protected $selectorWithVariant = '.{prefix}-{name}-{variant}';
protected $targets = [ 'desktop', 'mobile' ];
/**
* Constructs a new module from an options array.

1
includes/ResourceLoader/LanguageDataModule.php
View file

@ -31,7 +31,6 @@ use MediaWiki\MediaWikiServices;
* @internal
*/
class LanguageDataModule extends FileModule {
protected $targets = [ 'desktop', 'mobile' ];
/**
* Get all the dynamic data for the content language to an array.

1
includes/ResourceLoader/SiteModule.php
View file

@ -32,7 +32,6 @@ use MediaWiki\MainConfigNames;
*/
class SiteModule extends WikiModule {
/** @var string[] What client platforms the module targets (e.g. desktop, mobile) */
protected $targets = [ 'desktop', 'mobile' ];
/**
* Get list of pages used by this module

2
includes/ResourceLoader/SiteStylesModule.php
View file

@ -31,8 +31,6 @@ use MediaWiki\MainConfigNames;
* @internal
*/
class SiteStylesModule extends WikiModule {
/** @var string[] What client platforms the module targets (e.g. desktop, mobile) */
protected $targets = [ 'desktop', 'mobile' ];
/**
* Get list of pages used by this module

4
includes/ResourceLoader/SkinModule.php
View file

@ -33,10 +33,6 @@ use Wikimedia\Minify\CSSMin;
* @internal
*/
class SkinModule extends LessVarFileModule {
/**
* All skins are assumed to be compatible with mobile
*/
public $targets = [ 'desktop', 'mobile' ];
/**
* Every skin should define which features it would like to reuse for core inside a

1
includes/ResourceLoader/StartUpModule.php
View file

@ -46,7 +46,6 @@ use Wikimedia\RequestTimeout\TimeoutException;
* @internal
*/
class StartUpModule extends Module {
protected $targets = [ 'desktop', 'mobile' ];
private $groupIds = [
// These reserved numbers MUST start at 0 and not skip any. These are preset

1
includes/ResourceLoader/UserModule.php
View file

@ -34,7 +34,6 @@ use TitleValue;
*/
class UserModule extends WikiModule {
protected $origin = self::ORIGIN_USER_INDIVIDUAL;
protected $targets = [ 'desktop', 'mobile' ];
/**
* @param Context $context

2
includes/ResourceLoader/UserOptionsModule.php
View file

@ -39,8 +39,6 @@ class UserOptionsModule extends Module {
protected $origin = self::ORIGIN_CORE_INDIVIDUAL;
protected $targets = [ 'desktop', 'mobile' ];
/**
* @param Context $context
* @return string JavaScript code

1
includes/ResourceLoader/UserStylesModule.php
View file

@ -35,7 +35,6 @@ use TitleValue;
class UserStylesModule extends WikiModule {
protected $origin = self::ORIGIN_USER_INDIVIDUAL;
protected $targets = [ 'desktop', 'mobile' ];
/**
* @param Context $context